Fixed: Memory leak in ASMs2Dmx::getBoundary #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
jenkins build this with downstreams please |
Contributor
Author
|
I think the failure here is only due to OPM/IFEM-AdvectionDiffusion#40 which also affects the Boussinesq test. @akva2 you fix? |
Member
|
sorry about that, fixed now. |
Member
|
jenkins build this with downstreams please |
akva2
reviewed
Jan 24, 2020
| else if (!bou[iedge]) | ||
| // Store the pointer to the first basis' edge in bou, to avoid memory leak | ||
| // since it is dynamically allocated (will be deallocated by parent class). | ||
| // If invoked with basis > 1 (less likely), we still leak though.. |
Member
There was a problem hiding this comment.
that certainly happens in stokes applications. but it's an improvement of course.
Contributor
Author
There was a problem hiding this comment.
yes, but only when inhomo dirichlet on pressure (or when different basis for x and y-direction).
Ideally, it should have been handled inside the SplineSurface class (like for the trivariate class).
Also provide spline parameters to the Vec4 object in the boundary integration methods, to account for possible field evaluation there. The remaining changes are cosmetics only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also provide spline parameters to the Vec4 object in the boundary
integration methods, to account for possible field evaluation there.
The remaining changes are cosmetics only.
This (partly) replaces #289 which has been rebased beyond its original state.
It will remove a memory leak from the mixed NonLinEl tests (tQ2-Q1 and Q2Q1).
Have also tried to make the 2D and 3D implementations more similar to ease comparison.
Guess not that well covered by unit/regression tests yet, so please take look at it before approving.