Some cleanup of mixed LR #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
jenkins build this with downstreams please |
Changed: Return false instead of break in loop without threading.
and use it instead of auto in range-based loops for readability. Changed: Use getElement(iel) instead of elementBegin()+iel. Fixed: Don't increment element counter when skipping element not in current threading group when doing interface integral.
storing basis function derivatives w.r.t. parameter domain coordinates in the array intended for derivatives w.r.t. Cartesian coordinates
…d 2nd) derivatives of mixed basis functions w.r.t. Cartesian coordinates, including the Jacobian and Hessian matrices
Fixed: Solution transfer for mixed in 3D.
Contributor
Author
|
jenkins build this with downstreams please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This originates from #397 more than 3 years ago, and contains some cleanup (including fix of potential issues) of the ASMu[23]mx code, but is not directly related to the scope of that PR. Motivation: Less code-duplication, and easiear to compare 2D and 3D implementations (diff).