Diverse småtterier... #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akva2
reviewed
Dec 16, 2016
src/ASM/ASMs3D.C
Outdated
| return; | ||
|
|
||
| this->prescribe(node,dof,code); | ||
| if (node > -1) |
Contributor
Author
There was a problem hiding this comment.
0 eller -1 her blir hipp som happ, da verdien -1 blir fanget riktig i neste instans inne i ASMbase::prescribed --> ASMbase::getNodeID. Så resultatet blir det samme. Det ble satt -1 da det var slik i tilsvaredne 2D metoden, men vi kan endre til > 0 begge steder, så sparer man ett funksjonskall.
Member
|
other than (potentially) what i asked about it looks all good. |
kmokstad
force-pushed
the
dbgElm
branch
2 times, most recently
from
dba808d to
65003d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intet av dette bør trigge problemer, men man vet aldri...