Skip to content

Conversation

@kriben
Copy link
Collaborator

@kriben kriben commented Jan 5, 2026

Replaces the deprecated Clipper library with the actively maintained Clipper2 library.

Removes the local copy of the Clipper library and uses vcpkg to manage the dependency.

Fixes #11807

Replaces the deprecated Clipper library with the actively maintained Clipper2 library.

Removes the local copy of the Clipper library and uses vcpkg to manage the dependency.

Fixes #11807

Co-authored-by: Magne Sjaastad <magne.sjaastad@ceetronsolutions.com>
@kriben kriben requested a review from magnesj January 5, 2026 18:22
Copy link
Member

@magnesj magnesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pytest is failing. We need to add more unit tests to cover more use cases. The pytest detects changes in numerical precision.

Updates the unified completion export reference data to match Clipper2's
output. The Clipper2 upgrade introduces small numerical precision improvements
(4th-6th decimal places) in fishbone/perforation calculations due to better
intersection algorithms and edge case handling.
@kriben kriben requested a review from magnesj January 7, 2026 13:12
@kriben kriben merged commit 51b9508 into dev Jan 7, 2026
19 checks passed
@kriben kriben deleted the 11807-clipper2 branch January 7, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Clipper2

3 participants