Skip to content

Conversation

@ahmedxgouda
Copy link
Collaborator

Proposed change

Resolves #(put the issue number here)

Add the PR description here.

Checklist

  • Required: I read and followed the contributing guidelines
  • Required: I ran make check-test locally and all tests passed
  • I used AI for code, documentation, or tests in this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

Walkthrough

Reorganizes Docker Compose configuration by moving files to nested directories (docker-compose/e2e/ and docker-compose/fuzz/), updating relative paths from ../ to ../../, and renaming volumes with "-e2e" suffixes. Makefile references updated to point to new nested file locations.

Changes

Cohort / File(s) Summary
Docker Compose restructuring
docker-compose/local/compose.yaml, docker-compose/e2e/compose.yaml, docker-compose/fuzz/compose.yaml
Updated volume names with "-e2e" suffixes in local compose. Adjusted relative path references from ../ to ../../ in e2e and fuzz compose files to account for nested directory structure (build contexts, env_files, volume mounts).
Makefile path updates
backend/Makefile, frontend/Makefile
Updated docker compose file path references from docker-compose/e2e.yaml and docker-compose/fuzz.yaml to nested locations at docker-compose/e2e/compose.yaml and docker-compose/fuzz/compose.yaml in e2e and fuzz targets.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

docker, makefile

Suggested reviewers

  • arkid15r
  • kasya

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title is partially related to the changeset—it mentions updating volume names, which is a real aspect of the changes, but fails to capture the main objective of restructuring docker-compose file paths from flat to nested directory organization. Revise the title to focus on the primary change: restructuring docker-compose files into subdirectories (e2e and fuzz) and updating all path references accordingly.
Description check ❓ Inconclusive The description is a template with placeholder text ('Add the PR description here') and an unfilled issue link, providing no substantive information about the changeset. Replace template placeholders with an actual description explaining the volume naming changes, their purpose, and link to the related issue.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

PR validation failed: No linked issue and no valid closing issue reference in PR description

@github-actions github-actions bot closed this Dec 30, 2025
@ahmedxgouda ahmedxgouda linked an issue Dec 30, 2025 that may be closed by this pull request
2 tasks
@ahmedxgouda ahmedxgouda reopened this Dec 30, 2025
@ahmedxgouda ahmedxgouda marked this pull request as ready for review December 30, 2025 18:37
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
backend/apps/owasp/models/common.py (1)

238-256: LGTM! Cleaner regex pattern.

The regex refactor from [\s\S]*? to .*? with re.DOTALL is functionally equivalent and more idiomatic. Both patterns match any character including newlines in a non-greedy manner, but using . with the DOTALL flag is the standard Python approach.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7264151 and 4be37ae.

⛔ Files ignored due to path filters (2)
  • backend/poetry.lock is excluded by !**/*.lock
  • frontend/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • backend/apps/owasp/models/common.py
  • backend/pyproject.toml
  • docker-compose/local/compose.yaml
  • frontend/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-12-26T06:08:58.549Z
Learnt from: ahmedxgouda
Repo: OWASP/Nest PR: 3041
File: .github/workflows/run-ci-cd.yaml:233-243
Timestamp: 2025-12-26T06:08:58.549Z
Learning: Ensure Redis image versions stay in sync across all environments by updating every relevant YAML file together (docker-compose files and CI/CD workflow configurations). When upgrading Redis, bump the image version in all docker-compose files and in all CI workflow YAMLs in one coordinated change to maintain parity across production, staging, local, E2E, and CI tests.

Applied to files:

  • docker-compose/local/compose.yaml
📚 Learning: 2025-10-17T15:25:55.624Z
Learnt from: rudransh-shrivastava
Repo: OWASP/Nest PR: 2431
File: infrastructure/providers.tf:1-3
Timestamp: 2025-10-17T15:25:55.624Z
Learning: The infrastructure code in the OWASP/Nest repository (infrastructure/ directory) is intended for quick testing purposes only, not for production deployment.

Applied to files:

  • docker-compose/local/compose.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Run backend tests
  • GitHub Check: Run frontend e2e tests
  • GitHub Check: Run frontend unit tests
  • GitHub Check: Run fuzz tests
🔇 Additional comments (2)
docker-compose/local/compose.yaml (1)

33-33: Ensure the "-e2e" volume naming change is clearly communicated to developers.

Renaming volumes to add the "-e2e" suffix will create fresh Docker volumes, discarding any existing local development data (database records, Redis cache, installed dependencies). This is a breaking change for anyone with existing containers using the old volume names and should be clearly communicated to the team before merging.

frontend/package.json (1)

76-76: LGTM! Coordinated devDependencies upgrades.

The TypeScript ESLint tooling upgrades are properly coordinated across @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and typescript-eslint (all to ^8.51.0), which is important for compatibility. The @swc/core and eslint-plugin-jest upgrades are also appropriate. All specified package versions are available on npm.

@ahmedxgouda ahmedxgouda force-pushed the e2e/merge-and-volume-naming branch from 4be37ae to ffdae2e Compare December 31, 2025 04:31
@ahmedxgouda ahmedxgouda changed the title Add the last update and update volume names Update volume names Dec 31, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 31, 2025
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be split into 2 PRs:

  • one -- for the feature branch update w/ main
  • another -- for the volume names update

@arkid15r arkid15r marked this pull request as draft January 1, 2026 20:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

@ahmedxgouda ahmedxgouda marked this pull request as ready for review January 2, 2026 05:41
@ahmedxgouda ahmedxgouda requested a review from arkid15r January 2, 2026 05:41
@arkid15r arkid15r enabled auto-merge (squash) January 2, 2026 18:38
@arkid15r arkid15r disabled auto-merge January 2, 2026 18:45
@arkid15r arkid15r merged commit 6cf274a into OWASP:feature/e2e-backend Jan 2, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update volume names in e2e feature branch

2 participants