-
-
Notifications
You must be signed in to change notification settings - Fork 393
Update volume names #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update volume names #3102
Conversation
WalkthroughReorganizes Docker Compose configuration by moving files to nested directories (docker-compose/e2e/ and docker-compose/fuzz/), updating relative paths from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR validation failed: No linked issue and no valid closing issue reference in PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
backend/apps/owasp/models/common.py (1)
238-256: LGTM! Cleaner regex pattern.The regex refactor from
[\s\S]*?to.*?withre.DOTALLis functionally equivalent and more idiomatic. Both patterns match any character including newlines in a non-greedy manner, but using.with theDOTALLflag is the standard Python approach.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
backend/poetry.lockis excluded by!**/*.lockfrontend/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
backend/apps/owasp/models/common.pybackend/pyproject.tomldocker-compose/local/compose.yamlfrontend/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-12-26T06:08:58.549Z
Learnt from: ahmedxgouda
Repo: OWASP/Nest PR: 3041
File: .github/workflows/run-ci-cd.yaml:233-243
Timestamp: 2025-12-26T06:08:58.549Z
Learning: Ensure Redis image versions stay in sync across all environments by updating every relevant YAML file together (docker-compose files and CI/CD workflow configurations). When upgrading Redis, bump the image version in all docker-compose files and in all CI workflow YAMLs in one coordinated change to maintain parity across production, staging, local, E2E, and CI tests.
Applied to files:
docker-compose/local/compose.yaml
📚 Learning: 2025-10-17T15:25:55.624Z
Learnt from: rudransh-shrivastava
Repo: OWASP/Nest PR: 2431
File: infrastructure/providers.tf:1-3
Timestamp: 2025-10-17T15:25:55.624Z
Learning: The infrastructure code in the OWASP/Nest repository (infrastructure/ directory) is intended for quick testing purposes only, not for production deployment.
Applied to files:
docker-compose/local/compose.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Run backend tests
- GitHub Check: Run frontend e2e tests
- GitHub Check: Run frontend unit tests
- GitHub Check: Run fuzz tests
🔇 Additional comments (2)
docker-compose/local/compose.yaml (1)
33-33: Ensure the "-e2e" volume naming change is clearly communicated to developers.Renaming volumes to add the "-e2e" suffix will create fresh Docker volumes, discarding any existing local development data (database records, Redis cache, installed dependencies). This is a breaking change for anyone with existing containers using the old volume names and should be clearly communicated to the team before merging.
frontend/package.json (1)
76-76: LGTM! Coordinated devDependencies upgrades.The TypeScript ESLint tooling upgrades are properly coordinated across @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and typescript-eslint (all to ^8.51.0), which is important for compatibility. The @swc/core and eslint-plugin-jest upgrades are also appropriate. All specified package versions are available on npm.
4be37ae to
ffdae2e
Compare
arkid15r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be split into 2 PRs:
- one -- for the feature branch update w/
main - another -- for the volume names update
|



Proposed change
Resolves #(put the issue number here)
Add the PR description here.
Checklist
make check-testlocally and all tests passed