tests: ALRU inertia: don't clean below threshold #1694
Conversation
mmichal10
force-pushed
the
alru-threshold-tests
branch
from
d5d0f65 to
5eeaaa0
Compare
mmichal10
force-pushed
the
alru-threshold-tests
branch
from
5eeaaa0 to
902f9c9
Compare
| activity_threshold: int | None = None, | ||
| dirty_ratio_threshold: int | None = None, | ||
| dirty_ratio_inertia: Size | None = None, | ||
| dirty_ratio_inertia: int | None = None, |
There was a problem hiding this comment.
If I would change it I would change it the other way around - that is staleness_time: Time and so on
casadm.py for real life units, cas.py for string-converted
There was a problem hiding this comment.
the high level api in cache.py uses Time and Size. Do we need the real life units on two layers of the api?
There was a problem hiding this comment.
casadm.py is the everyday api - cache.py just has helpers
There was a problem hiding this comment.
What do you mean by every day api? If a test is testing the behavior of alru, what would be the benefit of using casadm.py api instead of the helper? casadm.py api can be used to test if casadm doesn't accept incorrect values (e.g. negative size) as it's more flexible, but apart from that tests should use the high level api. Besides, all the other functions in this file accept ints as params; how are alru params different from the other cache params?
mmichal10
force-pushed
the
alru-threshold-tests
branch
from
902f9c9 to
fb908b8
Compare
The casadm api expects that the ALRU params as ints, so the conversion from Size to int must happen in the higher level api Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
force-pushed
the
alru-threshold-tests
branch
2 times, most recently
from
b4e3b8b to
90f2a8f
Compare
Co-authored-by: aider (gpt-5) <aider@aider.chat> Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
force-pushed
the
alru-threshold-tests
branch
from
90f2a8f to
badbafb
Compare
Co-authored-by: aider (gpt-5) <aider@aider.chat> Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
mmichal10
force-pushed
the
alru-threshold-tests
branch
from
badbafb to
8e374bb
Compare
3 participants
No description provided.