Skip to content

Conversation

@Ostrokrzew
Copy link
Contributor

@Ostrokrzew Ostrokrzew commented Feb 19, 2021

Add the requirements for the casadm commands (including the script commands):

  • add-core
  • remove-core
  • remove-inactive
  • detach (script)
  • try-add (script)

Signed-off-by: Slawomir Jankowski slawomir.jankowski@intel.com

@Ostrokrzew Ostrokrzew added the RFC Request For Comments label Feb 19, 2021
Comment on lines 10 to 15
title: Remove active cache volume with dirty data with flush
id: remove_cache_volume_active_flush
---

While cache volume is active and contains dirty data, the management tool shall
allow to remove cache volume with flush.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the requirements are over specified. You added requirements for removing active&dirty and inactive core but you missed one for active&clean.

I would start with the requirement for removing core (without mentioning about any particular state) because that's the feature that CAS shall be able to handle. After this general statement I would add the requirements for flushing a dirty core before its removal, for optional skipping that step by giving additional confirmation and for interrupting the flushing.

Comment on lines 45 to 47
When active cache volume that contains dirty data is removed without flush,
the management tool shall not allow to interrupt the removal operation and the
cache volume shall be successfully removed with proper warning about displayed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is about management operations I would focus on writing requirements for what CAS shall support rather than what it shall not support. Btw with When active cache volume that contains dirty data is removed without flush (...) the cache volume shall be successfully removed you are implying that removing dirty core shall always succeed. I think it would be hard to implement

@arutk
Copy link
Contributor

arutk commented Mar 3, 2021

comment regarding the title: "add a few management requirements"

@Ostrokrzew Ostrokrzew changed the title Add few management requirements Add management requirements Mar 9, 2021
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
@Ostrokrzew Ostrokrzew removed the RFC Request For Comments label Mar 24, 2021
@Ostrokrzew Ostrokrzew changed the title Add management requirements doc: Add management requirements Mar 24, 2021
@CAS-Linux-Jenkins
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants