-
Notifications
You must be signed in to change notification settings - Fork 96
doc: Requirements for IO classes #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
doc/requirements/io_class
Outdated
| --- | ||
|
|
||
| The product shall allow to pin an IO class. Data from the pinned IO class shall | ||
| not be evicted unless its occupancy limit is not exceeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means the opposite of what I think you intended. It should be "unless its occupancy limit is exceeded".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data from -> cachelines assigned to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think stating that something should not happen in an unspecified set of circumstances makes it hard to test. Instead I would specify a set of requirements exactly describing expected eviction/replacement behavior. This would also explain the interdependencies between specific settings (pinning, eviction priority, max occupancy) which might be hard to deduce from the existing form. Let's discuss this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How exactly would you like to extend this req?
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
Signed-off-by: Michal Mielewczyk michal.mielewczyk@intel.com