Skip to content

Conversation

@mmichal10
Copy link
Contributor

Signed-off-by: Michal Mielewczyk michal.mielewczyk@intel.com

robertbaldyga
robertbaldyga previously approved these changes May 11, 2022
---

The product shall allow to pin an IO class. Data from the pinned IO class shall
not be evicted unless its occupancy limit is not exceeded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means the opposite of what I think you intended. It should be "unless its occupancy limit is exceeded".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data from -> cachelines assigned to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think stating that something should not happen in an unspecified set of circumstances makes it hard to test. Instead I would specify a set of requirements exactly describing expected eviction/replacement behavior. This would also explain the interdependencies between specific settings (pinning, eviction priority, max occupancy) which might be hard to deduce from the existing form. Let's discuss this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How exactly would you like to extend this req?

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants