Skip to content

Fix issue #99 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lohedges merged 4 commits into from
Dec 2, 2025
Merged

Fix issue #99 #100

lohedges merged 4 commits into from
Dec 2, 2025

Conversation

@lohedges
Copy link
Contributor

@lohedges lohedges commented Dec 2, 2025

This PR closes #99 by...

  • Make sure the user wants to save trajectories when setting the save_frames flag.
  • Making sure that trajectory chunk files exist before attempting to reconstruct and save the trajectory during the final checkpoint.
  • Removing an incorrect and redundant configuration option.

@lohedges lohedges added bug Something isn't working cresset Related to work with Cresset labels Dec 2, 2025
@lohedges lohedges merged commit 2f0c068 into devel Dec 2, 2025
4 checks passed
@lohedges lohedges deleted the fix_99 branch December 2, 2025 16:13
lohedges added a commit that referenced this pull request Dec 2, 2025
@lohedges
Backport fix from PR #100. [ci skip]
d307d35
@lohedges lohedges mentioned this pull request Dec 2, 2025
Merged
lohedges added a commit that referenced this pull request Dec 2, 2025
@lohedges
Merge pull request #101 from OpenBioSim/backport_100
918986c 
Backport fixes from PR #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working cresset Related to work with Cresset

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logic for deciding whether to save frames is duplicated

2 participants

@lohedges