[com1;General] Add module name to simName #1226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Components (1)
Modified Files with Diff Coverage (7)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
…imName` - Integrated `cfgUtils.parseSimName` to simplify extraction of simulation components across old and new formats. - Unified reconstruction logic for `simName` using parsed components and removed redundant conditions. - Updated corresponding logic in dataframe population to use parsed results for consistency. - Added extensive unit tests in `cfgUtils` to validate `parseSimName` functionality across different naming conventions and edge cases. - Minor refactors in test cases and `com1DFA` to align with new parsing logic. refactor(cfgUtils): streamline `parseSimName` to extract short module names - Updated `parseSimName` to extract short module names (e.g., "com1" instead of "com1DFA"). - Refactored multiple files to consistently use parsed components, replacing manual string parsing. - Modified tests to cover enhanced `parseSimName` behavior, removing dependency on legacy module patterns.
…odule name addition - Updated `cfgUtils` docstring with details about new and old simulation name formats, including components and structure. - Revised `com1DFA` documentation to reflect the addition of the short module name (`com1`) to simulation names - Noted backward compatibility with older naming conventions. refactor(fileHandlerUtils): replace `parsed` with `simNameParts` - Renamed variable `parsed` to `simNameParts` refactor(dfa2Aimec): simplify mass balance file sorting with lambda function
fso42
force-pushed
the
addModuleToName
branch
from
07f3d8d to
4f32040
Compare
8 tasks
Contributor
1 new issue
|
awirb
approved these changes
Dec 23, 2025
- Adjusted simulation name structure in docstrings and parsing logic - Updated examples for old and new formats to remove redundant brackets around `defID`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, simulation names follow the format:
This format lacks information about which computational module generated the simulation, making it difficult to:
New Format
Add
modNameas the third component:Example:
release1_a1b2c3_C_S_ent_dfarelease1_a1b2c3_com1DFA_C_S_ent_dfaBackward Compatibility
Implement a centralized parser that: