Skip to content

Conversation

@majklvi
Copy link
Contributor

@majklvi majklvi commented Dec 19, 2023

No description provided.

@janrysavy janrysavy added the comments translation Translation of code comments from Czech to English label Dec 20, 2023
if (msgBoxThread != NULL)
{
WaitForSingleObject(msgBoxThread, INFINITE); // pokud se da TRACE_C do DllMain do DLL_THREAD_ATTACH, dojde k deadlocku - silne nepravdepodobne, neresime
WaitForSingleObject(msgBoxThread, INFINITE); // if TRACE_C is in DllMain to DLL_THREAD_DETACH, deadlock will occur - very unlikely, not solved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unlikely, ignored

else // ostatni thready s TRACE_C zablokujeme, az se zavre msgbox otevreny pro
{ // prvni TRACE_C, tak to tam i spadne, at v tom neni bordel
else // we will block another threads with TRACE_C, once the msgbox, opened
// for the first TRACE_C, is closed, it will be passed there, so that there is no mess
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be passed there, so that there is no mess
->
so it will crash there, to avoid a mess

{
while (1)
Sleep(1000); // blokace vede na deadlock napr. kdyz je (a nema byt) TRACE_C v DLL_THREAD_DETACH
Sleep(1000); // blocking leads to deadlock, e.g. when TRACE_C is in DLL_THREAD_DETACH (but it should not)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but it should not) -> (and should not be)

// SPDX-License-Identifier: GPL-2.0-or-later

// CommentsTranslationProject: TRANSLATED
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty comment

// CALL-STACK is disabled by defining CALLSTK_DISABLE macro

// CAUTION: TRACE_C can't be used in DllMain of libraries, nor in any code called from DllMain,
// otherwise deadlock occurs, see implementation of C__Trace::SendMessageToServer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align otherwise with TRACE_C (column)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comments translation Translation of code comments from Czech to English

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants