pictview: added support for viewing .heif and .webp files

[lejcik]

Added experimental support for viewing .heif and .webp image files into PictView plugin.

For more details see the discussion here: #36

NOTE: This feature is not ready to be merged, and that this pull request will stay as a draft.

[melloware]

@lejcik you are my hero ❤️

[melloware]

cc @WaldemarH would love your eyes on this and any opinion? The PictView plugin is one of the most useful and popular plugins!

[lejcik]

it will take a while to set up automated builds, but those who want to try out the updated PictView plugin, you can download it from here: https://uschovna.cz/zasilka/RG2D5WT7IRNEC89S-XS5

[melloware]

I just tried the x64 version and I keep getting this...

[lejcik]

strange, on my PC it works well,

ok, firstly go to menu plugins/plugin manager and try to test this plugin, if it fails, try to load other plugins if possible (just to test if you have the VC redistributables installed on your PC),

if it still fails to load, try to use procmon tool, and watch what dlls is salamander trying to load, and which dll it can't find,

or try out the x86 build,

I may try out to run this build on a clean system on virtual machine, but I don't have time for that now...

[ags1234]

Ok, downloaded Open Salamander 5.0 x64, Windows 10 x64 22H2
No plugin errors here.

But webp files are displayed as hex, not as picture.

[melloware]

I assume my issue is I don't have the VC++ Redistributable of the version you are building with?

[ags1234]

@melloware
If missing any VC++ redistributable: https://github.com/abbodi1406/vcredist

[lejcik]

But webp files are displayed as hex, not as picture.

this may happen if salamander configuration was imported from previous version, but if you load the plugin (e.g. via plugin manager, click on test button), it will update salamander configuration, and register new file extensions,

also test if thumbnails are displayed well,

[melloware]

OK i did do import my configuration when it asked me how do I back that out?

[ags1234]

@lejcik
Salamander 5 offered to import config from Salamander 4 but i refused, and checked to delete it.
I also clicked on Test button, and also restarted OS 5, but webp pictures still show as hex.

Thumbnails are shown ok for webp.

[melloware]

OK confirmed the VC++ issue that @ags1234 posted fixed me up and .WEBP show up fine for me!

[lejcik]

... but webp pictures still show as hex.

check if file extension is registered in salamander, go to menu options/configuration/viewers and there's a list of file extensions, if there's no *.webp, you can add it to the list and assign it to PictView plugin, but plugin should register it once it is loaded,

[ags1234]

... but webp pictures still show as hex.

check if file extension is registered in salamander, go to menu options/configuration/viewers and there's a list of file extensions, if there's no *.webp, you can add it to the list and assign it to PictView plugin, but plugin should register it once it is loaded,

Registered *.webp and associated it with PictView (Plugin). Even closed OS and reopened and still hex on any webp files.
The following work fine wirh F3: jpg, png, gif.
There's still something in the code of PictView that makes it not recognize webp as a picture, but as a bniary file.

[melloware]

Just confirming I went here: https://developers.google.com/speed/webp/gallery1 downloaded an example webp file and its opens with F3 for me. Could it be that particular WEBP you are trying to open?

[tormento]

it will take a while to set up automated builds, but those who want to try out the updated PictView plugin, you can download it from here: https://uschovna.cz/zasilka/RG2D5WT7IRNEC89S-XS5

The download isn't available anymore, could you mirror it?

[lejcik]

The download isn't available anymore, could you mirror it?

this was a plugin for salamander 5, if you can compile salamander from the sources, you can also compile this plugin 🙂

try out rather the latest official salamander 4 release (download it here) and follow the instructions in my comment #90 (comment)

[tormento]

I found a build of AS 5. Please share your plugin ;)

[lejcik]

ok, here is the pictview plugin for salamander 5:

• pictview-x86.zip
• pictview-x64.zip

the install instructions stay the same as in my comment above... does the plugin work well?

[tormento]

@lejcik I unpacked the archive so that the dll's are in Salamander root folder and the slp in Plugins/Pictview

I get the error:

Perhaps it's the Salamander build that I've found. Could you share your x64 one?

[lejcik]

I forgot to attach the language file to the archives, I updated the links in my comment above, download the plugin again, hopefully it will work now,

ensure that you downloaded plugin for your salamander architecture: x86 or x64 - see the salamander main window title

[tormento]

I've downloaded the last available build of x64 Open Salamander.

There is a PictView plugin directory already but that version is not working.

Tried to delete that and replaced with yours and still not working. :(

[lejcik]

I've downloaded the last available build of x64 Open Salamander.

I know what is wrong - the salamander 5 build is not complete, see the note about PictView in the readme file, the PictView engine pvw32cnv.dll is not open-sourced, and that it is not distributed with this project, however you can take this .dll file from salamander 4 and copy it manually into your salamander 5 binaries, then the plugin will work,

moreover, if you use x64 version, you need also salpvenv.exe utility (used for communication between 64-bit process and 32-bit .dll), which cannot be compiled without pvw32cnv.lib, but you can also take it from salamander 4,

I'd recommend you staying with salamander 4, version 5 is still under development and is not stable yet...