feat: Add option for random behavior on pull trigger #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NekoTiki <17910933+nekotiki@users.noreply.github.com>
Contributor
Author
|
Saw some edge cases where it didn't work properly
|
…onditions being met Signed-off-by: NekoTiki <17910933+NekoTiki@users.noreply.github.com>
Contributor
Author
|
Fixed the cooldown issue and after testing the pull always behind at zero was my phys bone being configured badly 😄 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new feature that allows users to enable random intensity behavior when pull triggers are activated, instead of using distance-based intensity calculations. This addresses issue #44 by providing an alternative shock behavior mode.
- Added a new boolean configuration option
OnPullTriggerRandomBehaviorto control random intensity behavior - Updated both global and group-specific UI configurations to include the new pull trigger random option
- Modified the physbone handling logic to use random intensity selection when this option is enabled
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| SharedBehaviourConfig.cs | Added new boolean property for pull trigger random behavior configuration |
| GroupsTab.razor | Added UI checkbox and tooltip for group-specific pull trigger random behavior setting |
| ConfigTab.razor | Added UI checkbox and tooltip for global pull trigger random behavior setting |
| ShockOsc.cs | Implemented logic to check random behavior setting and use random intensity when enabled |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications toward this issue: #44