Fixing Cmake fallback python folder detection (to not return /usr/local) #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is breaking on some build servers, due to returning an absolute path that is installed outside of the install prefix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1025 +/- ##
===========================================
+ Coverage 59.60% 60.91% +1.31%
===========================================
Files 206 206
Lines 20374 22555 +2181
===========================================
+ Hits 12143 13740 +1597
- Misses 8231 8815 +584 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing python install detected folder, to be relative folder. This is breaking on some Launchpad build servers, due to returning an absolute path that is installed outside of the install prefix. Just tightening up the python fallback when looking for the correct folder.