Skip to content

Conversation

@Stef-Rousset
Copy link
Contributor

@Stef-Rousset Stef-Rousset commented Nov 19, 2025

🎩 Description

This PR overrides the FindAndUpdateDescendantsJob to improve its speed execution and avoid timeout when updating, publishing/unpublishing a participatory space.
Override by @AyakorK, and tests by myself.

Testing

  1. As an admin, go to a published assembly with components and unpublish it
  2. See that the unpublishing action takes around 10 seconds (40 seconds before improvment)
  3. In the FO, go to the search bar, and search for a child of the assembly, for instance search a meeting by its title
  4. See that the meeting is not found (proving that the job has been correctly executed)
  5. Go to the BO again and publish the assembly
  6. Repeat step 3 and see that you find the meeting
  7. Go to the BO again and update the assembly
  8. Repeat step 6

📌 Related Issues

Tasks

  • Add specs

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

@Stef-Rousset Stef-Rousset marked this pull request as ready for review November 19, 2025 15:39
@BarbaraOliveira13 BarbaraOliveira13 added the Override:pending Override en attente de review / nettoyage label Dec 1, 2025
Copy link
Contributor

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected locally 🎉

Great job! Maybe add a test with a “big” assembly: for example, one containing 5 components, each with ~200 proposals, and each proposal having ~10 comments...
What do you think? @Stef-Rousset @moustachu ?

Instead LGTM !

@Bertille-M
Copy link

@Stef-Rousset Is there any thing else to do on this PR ?

@BarbaraOliveira13 BarbaraOliveira13 self-requested a review December 10, 2025 15:03
@BarbaraOliveira13 BarbaraOliveira13 merged commit bc0e92f into develop Dec 10, 2025
10 checks passed
@BarbaraOliveira13 BarbaraOliveira13 deleted the fix/malakoff_assembly_edit branch December 10, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Override:pending Override en attente de review / nettoyage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants