Skip to content

Conversation

@Stef-Rousset
Copy link
Contributor

@Stef-Rousset Stef-Rousset commented Dec 3, 2025

🎩 Description

This PR fixes the order of proposals in paginated proposals index.

Testing

  1. In the FO, go to a process that have more than 25 proposals.
  2. Note the order of proposals on the first page, navigate to the second page and go back to first page. Ensure that the proposals's order hasn't change on first page.
  3. Apply the filter "all" in the state filter.
  4. Repeat step 2

📌 Related Issues

Link your PR to an issue

Tasks

  • Add specs

@Stef-Rousset Stef-Rousset marked this pull request as ready for review December 3, 2025 14:12
Copy link
Contributor

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the product review: GREAT 🎉

About the tech review: I should use the .prepend method instead of .include so we don’t need to override the entire proposals index controller. It would be better for maintainability if Decidim changes that part of the code in the future… though maybe it’s a bit superficial...
…but I don’t see any problematic breakdown here 👍
Should we not add @moustachu as reviewer ? :s

@Stef-Rousset Stef-Rousset added the Override:pending Override en attente de review / nettoyage label Dec 10, 2025
@Stef-Rousset
Copy link
Contributor Author

Stef-Rousset commented Dec 10, 2025

About the product review: GREAT 🎉

About the tech review: I should use the .prepend method instead of .include so we don’t need to override the entire proposals index controller. It would be better for maintainability if Decidim changes that part of the code in the future… though maybe it’s a bit superficial... …
Instead, I don’t see any problematic breakdown here 👍
Should we not add @moustachu as reviewer ? :s

Hello, thx for your review ! I am not sure to understand the change you suggested, could you provide a detailed explanation 🙏?

@Stef-Rousset Stef-Rousset added the Before migration 0.31 Date / situation prévue pour re-valider la pertinence de l'override ou besoin de supprimer label Dec 10, 2025
@luciegrau luciegrau requested a review from AyakorK December 18, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Before migration 0.31 Date / situation prévue pour re-valider la pertinence de l'override ou besoin de supprimer Override:pending Override en attente de review / nettoyage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants