Fix accessibility on tabbed partial #1283
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR improves accessibility on tabbed partial :
role="menu"onul id="dropdown-menu-pages"androle="menuitem"onliaria-hiddenvalue onul id="dropdown-menu-pages"when clicking on windowaria-currenton activeaby for "page"Those issues come from the audit of Angers city (page 56), and they refer to criterias 2.5.3, 4.1.2, 1.3.2, 4.1.2, 1.3.3 and 4.1.1 from WCAG
📌 Related Issues
Testing
ul id="dropdown-menu-pages"and itslichildren have no attribute rolelithat thealink has aaria-current="page", and check that inside non activelithearia-currentonahas a false value📷 Screenshots (optional)