Skip to content

Conversation

@Stef-Rousset
Copy link

@Stef-Rousset Stef-Rousset commented Jul 10, 2025

🎩 What? Why?

This PR improves accessibility on tabbed partial :

  • it removes the role="menu" on ul id="dropdown-menu-pages" and role="menuitem" on li
  • it prevents the changing of aria-hidden value on ul id="dropdown-menu-pages" when clicking on window
  • it changes the value of aria-current on active a by for "page"

Those issues come from the audit of Angers city (page 56), and they refer to criterias 2.5.3, 4.1.2, 1.3.2, 4.1.2, 1.3.3 and 4.1.1 from WCAG

📌 Related Issues

Testing

  1. As a user, go to the footer of decidim page and in "Help" column, click on "General"
  2. Open you devTools, check that the ul id="dropdown-menu-pages" and its li children have no attribute role
  3. Check inside active li that the a link has a aria-current="page", and check that inside non active li the aria-current on a has a false value
  4. Click anywhere on window and check that ul aria-hidden attribute value is still false

📷 Screenshots (optional)

Capture d’écran 2025-07-10 à 10 58 46

@stale
Copy link

stale bot commented Oct 16, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. @carolromero & @xabier feel free to chime in.

@stale stale bot added the wontfix under the radar label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants