forked from decidim/decidim
-
Notifications
You must be signed in to change notification settings - Fork 5
Fix accessibility on new registration form #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Stef-Rousset
wants to merge
33
commits into
develop
Choose a base branch
from
fix/input_assistance_indications
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00ef22d to
84be711
Compare
77a15c8 to
af26a64
Compare
af26a64 to
4a75eea
Compare
…ssistance_indications
* New translations en.yml (Swedish) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Basque) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Spanish, Mexico) * New translations en.yml (French, Canada) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Catalan, Algherese) * New translations en.yml (German) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Finnish (plain)) * New translations en.yml (French) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (French, Canada) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Catalan, Algherese) * New translations en.yml (Basque) * New translations en.yml (Korean) * New translations en.yml (Vietnamese) * New translations en.yml (Persian) * New translations en.yml (Maltese)
* Error handling of not found resources * Fix Page specs * Add I18n support for not found error * Fix i18n key * Fix locales * Fix failing specs * Add error code token * Rename context from graphQL hidden space to graphQL not found space * Address other review comments
* Refactor API location * Add Proposal answer mutation example * Add link to decidim docs website * Process page announcement bug fix with system test (decidim#15616) Co-authored-by: Leo <leo.storey@mainiotech.fi> * Add debug permissions * Fix exception * Error handling of not found resources * Fix Page specs * Add I18n support for not found error * Fix i18n key * Fix locales * Fix failing specs * Adjust some of the existing mutations * Add error code token * Rename context from graphQL hidden space to graphQL not found space * Address other review comments * Fix typo * Fix some types * Fix failing specs * Fix failing specs * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix NuValidator image * Apply review recommendations * Update decidim-api/lib/decidim/api/test/component_context.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Leo Storey <123873192+Ginger-Leo@users.noreply.github.com> Co-authored-by: Leo <leo.storey@mainiotech.fi> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…5768) * Refactor QueryType to API * Remove bullet error * Remove unneded autoload * Fix typo * Disable bullet * Fix bullet error
* Extract each one spec in own test * Fix budgets specs * Add propsoals specs * Fix failing specs * Update decidim-proposals/spec/system/proposals_breadcrumbs_spec.rb Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update decidim-accountability/spec/system/explore_versions_spec.rb Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Extract results * Extract surveys specs * Extract surveys specs part 2 * Fully extract proposals * Fully extract proposals * Fix typo * Extract meeetings * Extract elections * Extract debates * Extract collaborative texts * Extract blogs * Create uniform specs * Fix filename * Apply review recommendations * Standardize tests * Fix specs --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
* Add AWS Bucket configuration for public assets * Fix typo * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/modules/services/pages/activestorage.adoc * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update docs/modules/services/pages/activestorage.adoc Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> Co-authored-by: Leo <leo.storey@mainiotech.fi>
…decidim#15787) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* condition to display responses in dropdown * i18n transalation for responses * Update decidim-surveys/app/views/decidim/surveys/admin/surveys/index.html.erb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-surveys/config/locales/en.yml Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-surveys/config/locales/en.yml Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * updated the icon for responses tab * route for admin added in spec, specs for responses and no responses added * fixed translation conflict from suggestion --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Leo <leo.storey@mainiotech.fi>
* Refactor API documentation * Fix typos * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Apply more review recommendations * Apply more review recommendations - error pages * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Move FormFactory to be accessible from API * Add missing method * Apply review recommendation
* Refactor API to raise and catch Decidim::PermissionAction::PermissionNotSetError exceptions * Add Decidim::Api::Errors::MutationNotAuthorizedError * Add Decidim::Api::Errors::ValidationError * Add Decidim::Api::Errors::AttributeValidationError * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix spec * Add test example * Refactor file name * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply review recommendation * Fix spec * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * change the variable name * Add additional I18n related exceptions * Refactor error layer * Fix error class tokens * Fix the initiatives specs * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Running linters * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Refactor API to raise and catch Decidim::PermissionAction::PermissionNotSetError exceptions * Add Decidim::Api::Errors::MutationNotAuthorizedError * Add Decidim::Api::Errors::ValidationError * Add Decidim::Api::Errors::AttributeValidationError * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix spec * Add test example * Refactor file name * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply review recommendation * Fix spec * Add mutation to vote Proposals via API * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * change the variable name * Add additional I18n related exceptions * Refactor error layer * Fix error class tokens * Fix the initiatives specs * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Running linters * Refactor API documentation * Fix typos * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review * Refactor documentation * Apply review recommendations * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Removed comment --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
configuration
dependencies
Pull requests that update a dependency file
module: accountability
module: admin
module: ai
module: api
module: assemblies
module: blogs
module: budgets
module: collaborative_texts
module: comments
module: conferences
module: core
module: debates
module: demographics
module: design
module: dev
module: elections
module: forms
module: generators
module: initiatives
module: meetings
module: pages
module: participatory processes
module: proposals
module: sortitions
module: surveys
module: system
module: templates
module: verifications
team: documentation
type: fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR improves accessibility on new registration form, by:
sr-only spansr-only span, and by linking the term of services text with its input witharia-describedbyThis PR is issued from the audit of Angers city (pages 97 and 98), and refers to criterias 3.3.1 and 3.3.2 from WCAG.
📌 Related Issues
https://github.com/orgs/OpenSourcePolitics/projects/26/views/1?pane=issue&itemId=122486764&issue=OpenSourcePolitics%7Cintern-tasks%7C90
Testing
📷 Screenshots