Skip to content

Conversation

@Stef-Rousset
Copy link

🎩 What? Why?

This PR improves accessibility on new registration form, by:

  • adding an indication of expected format for email with sr-only span
  • indicating that terms of service is required with sr-only span, and by linking the term of services text with its input with aria-describedby

This PR is issued from the audit of Angers city (pages 97 and 98), and refers to criterias 3.3.1 and 3.3.2 from WCAG.

📌 Related Issues

Testing

  1. As a non logged in user, go to the signup page
  2. Activate your screenreader and navigate to the email field
  3. Ensure that an example of format for email is read
  4. Navigate to the terms of service field
  5. Ensure that the indication of required field is read
  6. When you navigate on the checkbox, ensure that the terms of service text is read

📷 Screenshots

Capture d’écran 2025-08-21 à 15 06 21

Capture d’écran 2025-08-21 à 15 05 52

♥️ Thank you!

@Stef-Rousset Stef-Rousset force-pushed the fix/input_assistance_indications branch from 00ef22d to 84be711 Compare August 22, 2025 07:08
@Stef-Rousset Stef-Rousset force-pushed the fix/input_assistance_indications branch from 77a15c8 to af26a64 Compare September 1, 2025 10:09
@Stef-Rousset Stef-Rousset force-pushed the fix/input_assistance_indications branch from af26a64 to 4a75eea Compare September 8, 2025 15:21
decidim-bot and others added 28 commits December 9, 2025 17:30
* New translations en.yml (Swedish)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Japanese)

* New translations en.yml (Basque)

* New translations en.yml (German)

* New translations en.yml (Basque)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Swedish)

* New translations en.yml (Turkish)

* New translations en.yml (Turkish)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (French, Canada)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Catalan, Algherese)

* New translations en.yml (German)

* New translations en.yml (Finnish)

* New translations en.yml (Finnish)

* New translations en.yml (Finnish)

* New translations en.yml (German)

* New translations en.yml (Basque)

* New translations en.yml (Basque)

* New translations en.yml (Basque)

* New translations en.yml (Finnish)

* New translations en.yml (Finnish)

* New translations en.yml (Finnish)

* New translations en.yml (Finnish)

* New translations en.yml (Turkish)

* New translations en.yml (Finnish (plain))

* New translations en.yml (Czech)

* New translations en.yml (Czech)

* New translations en.yml (Czech)

* New translations en.yml (Czech)

* New translations en.yml (Czech)

* New translations en.yml (Basque)

* New translations en.yml (Italian)

* New translations en.yml (Finnish (plain))

* New translations en.yml (French)

* New translations en.yml (Czech)

* New translations en.yml (Czech)

* New translations en.yml (French, Canada)

* New translations en.yml (Finnish (plain))

* New translations en.yml (Finnish (plain))

* New translations en.yml (Finnish (plain))

* New translations en.yml (Finnish (plain))

* New translations en.yml (Finnish (plain))

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Basque)

* New translations en.yml (Swedish)

* New translations en.yml (Turkish)

* New translations en.yml (Turkish)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Catalan, Algherese)

* New translations en.yml (Basque)

* New translations en.yml (Korean)

* New translations en.yml (Vietnamese)

* New translations en.yml (Persian)

* New translations en.yml (Maltese)
* Error handling of not found resources

* Fix Page specs

* Add I18n support for not found error

* Fix i18n key

* Fix locales

* Fix failing specs

* Add error code token

* Rename context from graphQL hidden space to graphQL not found space

* Address other review comments
* Refactor API location

* Add Proposal answer mutation example

* Add link to decidim docs website

* Process page announcement bug fix with system test (decidim#15616)

Co-authored-by: Leo <leo.storey@mainiotech.fi>

* Add debug permissions

* Fix exception

* Error handling of not found resources

* Fix Page specs

* Add I18n support for not found error

* Fix i18n key

* Fix locales

* Fix failing specs

* Adjust some of the existing mutations

* Add error code token

* Rename context from graphQL hidden space to graphQL not found space

* Address other review comments

* Fix typo

* Fix some types

* Fix failing specs

* Fix failing specs

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Fix NuValidator image

* Apply review recommendations

* Update decidim-api/lib/decidim/api/test/component_context.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Leo Storey <123873192+Ginger-Leo@users.noreply.github.com>
Co-authored-by: Leo <leo.storey@mainiotech.fi>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…5768)

* Refactor QueryType to API

* Remove bullet error

* Remove unneded autoload

* Fix typo

* Disable bullet

* Fix bullet error
* Extract each one spec in own test

* Fix budgets specs

* Add propsoals specs

* Fix failing specs

* Update decidim-proposals/spec/system/proposals_breadcrumbs_spec.rb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update decidim-accountability/spec/system/explore_versions_spec.rb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Extract results

* Extract surveys specs

* Extract surveys specs part 2

* Fully extract proposals

* Fully extract proposals

* Fix typo

* Extract meeetings

* Extract elections

* Extract debates

* Extract collaborative texts

* Extract blogs

* Create uniform specs

* Fix filename

* Apply review recommendations

* Standardize tests

* Fix specs

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
* Add AWS Bucket configuration for public assets

* Fix typo

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update docs/modules/services/pages/activestorage.adoc

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update docs/modules/services/pages/activestorage.adoc

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Leo <leo.storey@mainiotech.fi>
…decidim#15787)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* condition to display responses in dropdown

* i18n transalation for responses

* Update decidim-surveys/app/views/decidim/surveys/admin/surveys/index.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-surveys/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-surveys/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* updated the icon for responses tab

* route for admin added in spec, specs for responses and no responses added

* fixed translation conflict from suggestion

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Leo <leo.storey@mainiotech.fi>
* Refactor API documentation

* Fix typos

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Apply more review recommendations

* Apply more review recommendations - error pages

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Move FormFactory to be accessible from API

* Add missing method

* Apply review recommendation
* Refactor API to raise and catch Decidim::PermissionAction::PermissionNotSetError exceptions

* Add Decidim::Api::Errors::MutationNotAuthorizedError

* Add Decidim::Api::Errors::ValidationError

* Add Decidim::Api::Errors::AttributeValidationError

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix spec

* Add test example

* Refactor file name

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply review recommendation

* Fix spec

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* change the variable name

* Add additional I18n related exceptions

* Refactor error layer

* Fix error class tokens

* Fix the initiatives specs

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Running linters

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Refactor API to raise and catch Decidim::PermissionAction::PermissionNotSetError exceptions

* Add Decidim::Api::Errors::MutationNotAuthorizedError

* Add Decidim::Api::Errors::ValidationError

* Add Decidim::Api::Errors::AttributeValidationError

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix spec

* Add test example

* Refactor file name

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply review recommendation

* Fix spec

* Add mutation to vote Proposals via API

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* change the variable name

* Add additional I18n related exceptions

* Refactor error layer

* Fix error class tokens

* Fix the initiatives specs

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Running linters

* Refactor API documentation

* Fix typos

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

* Apply suggestions from code review

* Refactor documentation

* Apply review recommendations

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Removed comment

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment