Skip to content

Fix build error when using CMake find_package config search mode for Boost #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
francisduffy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build error when using CMake find_package config search mode for Boost #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0cc5cf
Allow users to have an untracked CMakeUserPresets.json file.
francisduffy Nov 26, 2025
a8e98c4
Add Boost libraries missing in link step.
francisduffy Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,4 +350,4 @@ Examples/**/pricingstats.csv
*.fls

.gitmodules

CMakeUserPresets.json
2 changes: 1 addition & 1 deletion ORE-SWIG/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ get_library_name("QuantExt" QLE_LIB_NAME)
set_ql_library_name()

# To build the module, we moreover need Boost, Swig, Python
set(BOOST_COMPONENT_LIST serialization date_time filesystem timer thread log)
set(BOOST_COMPONENT_LIST serialization date_time filesystem timer thread log regex)


if(ORE_USE_ZLIB)
Expand Down
2 changes: 1 addition & 1 deletion OREData/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ else()
SET(COMPONENTS_CONDITIONAL "")
endif()

find_package (Boost REQUIRED COMPONENTS ${COMPONENTS_CONDITIONAL} date_time thread serialization timer log filesystem OPTIONAL_COMPONENTS system chrono)
find_package (Boost REQUIRED COMPONENTS ${COMPONENTS_CONDITIONAL} date_time thread serialization timer log_setup log filesystem OPTIONAL_COMPONENTS system chrono)


include_directories(${Boost_INCLUDE_DIRS})
Expand Down
2 changes: 1 addition & 1 deletion QuantExt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ else()
endif()


find_package (Boost REQUIRED COMPONENTS ${COMPONENTS_CONDITIONAL} date_time thread serialization timer log filesystem OPTIONAL_COMPONENTS system chrono)
find_package (Boost REQUIRED COMPONENTS ${COMPONENTS_CONDITIONAL} date_time thread serialization timer log_setup log filesystem OPTIONAL_COMPONENTS system chrono)


if (ORE_ENABLE_PARALLEL_UNIT_TEST_RUNNER AND UNIX AND NOT APPLE)
Expand Down