Do not explicitly disable SSLv3 #287
Merged
+0
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSLv3 is long gone, we could also probably also disable TLS 1.0 and 1.1, but [recent changes in the openssl gem freeze the default parameters](ruby/openssl#925), and the default configuration seems to have the correct behavior on the systems I tested, refusing to connect to hosts with anything older than TLS 1.2. Drop this monkey patching to unbreak with version 4.0.0 of the openssl gem. Fixes OpenVoxProject/openbolt#169
smortex
force-pushed
the
remove-sslv3-monkey-patch
branch
from
6e2d29f to
e79be53
Compare
nmburgan
approved these changes
Dec 23, 2025
TheMeier
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSLv3 is long gone, we could also probably also disable TLS 1.0 and 1.1,
but recent changes in the openssl gem freeze the default parameters, and
the default configuration seems to have the correct behavior on the
systems I tested, refusing to connect to hosts with anything older than
TLS 1.2.
Drop this monkey patching to unbreak with version 4.0.0 of the openssl
gem.
Fixes OpenVoxProject/openbolt#169