General improvements #1492
Open
General improvements #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to load the CML SINIT ACM for tboot to use it.
sshd argo is purely internal to the host. We don't need to use multiple ssh host keys since a single one will be compatible with out provided client ssh. Select ed25519 since it is fast and generally preferred. This means we can drop generating ecdsa, dsa & rsa. Change the bbappend seddery to just modify the single entry. Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Only listed on localhost since it doesn't need to be on the network. Monit has trouble with "localhost" so use 127.0.0.1.
This adds udev rules to apply the argo group ownership to /dev/argo*. This helps with deprivileging processes so they don't have to run as root. It's subpackage and will be added as an RRECOMMENDS in most cases.
libargo is useless without argo-module. Add that RDEPENDS and remove all the manual IMAGE_INSTALLs of argo-module from image recipes. Proper dependency tracking takes care of that for us. Since KERNEL_MODULE_AUTOLOAD is set properly for argo-module/xen-argo, this is all much nicer.
domstore_read is a open-coding of db-read-dom0 from dbd-tools-guest, so just replace the use.
crogers1
approved these changes
Aug 7, 2025
Contributor
crogers1
left a comment
crogers1
left a comment
There was a problem hiding this comment.
I like these improvements. LGTM.
shahs-ais
reviewed
Aug 8, 2025
| PACKAGES = "${PN}" | ||
|
|
||
| RDEPENDS_${PN} += "dbd-tools" | ||
| RDEPENDS_${PN} += "dbd-tools-guest" |
Contributor
There was a problem hiding this comment.
My local build fails here as dbd-tools-guest is not found. From what is see in dbd_git.bb, only dbd-tools and dbd-tools-vm packages are created. Was another one meant to be added for guest?
Contributor
There was a problem hiding this comment.
Looking at the recipes, this should be dbd-tools-vm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides general improvements to a series of recipes in the layer.
Signed-off-by: Daniel P. Smith dpsmith@apertussolutions.com