Skip to content

Conversation

@shahs-ais
Copy link
Contributor

Uprev to network-manager v1.16.0 and network-manager-applet v1.22.10 and revising associated patches

@shahs-ais shahs-ais force-pushed the shahs/UprevNetworkManager branch from 0421d31 to fff2d60 Compare May 13, 2025 16:28
@crogers1 crogers1 requested review from crogers1 and dpsmith May 13, 2025 16:35
@shahs-ais shahs-ais force-pushed the shahs/UprevNetworkManager branch from fff2d60 to abb034d Compare May 14, 2025 13:30
@dpsmith
Copy link
Member

dpsmith commented Jun 27, 2025

Your commit really needs to be broken up to provide a clean evolution. libnma recipe should be its own commit followed by a commit that moves the applet patch and cleans up the applet recipe. And why did you lock the files folder to .10 for networkmanager instead of .%. Doing this will cause unnecessary patch churn if we have to do a bug update.

@shahs-ais
Copy link
Contributor Author

Your commit really needs to be broken up to provide a clean evolution. libnma recipe should be its own commit followed by a commit that moves the applet patch and cleans up the applet recipe. And why did you lock the files folder to .10 for networkmanager instead of .%. Doing this will cause unnecessary patch churn if we have to do a bug update.

Will break it up into more reasonable slices, thanks. I was under the impression that we wanted to have the package versions locked for stability reasons, maybe I misunderstood this - will discuss with Chris as well.

@shahs-ais shahs-ais force-pushed the shahs/UprevNetworkManager branch from abb034d to 2e34bde Compare June 27, 2025 18:16
Update versions for nm applet/backend recipes and remove old version
libnma is no longer checked in with network-manager-applet, so adding package separately and patching the necessary file here
Revising patches based on source code updates/refactoring and changes to build systems with new network-manager and network-manager-applet versions
@shahs-ais shahs-ais force-pushed the shahs/UprevNetworkManager branch from 2e34bde to ea7e98a Compare June 27, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants