Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Apr 27, 2025

This PR contains the following updates:

Package Type Update Change
node final digest 9bef0ef0340fa6
node stage digest 9bef0ef0340fa6

Configuration

📅 Schedule: Branch creation - "on sunday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Apr 27, 2025
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal April 27, 2025 04:03
Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本次代码变更有以下几点:

  • 更新了三个 Dockerfile 中的 node:22-alpine 基础镜像的 SHA256 校验值
  • 前两个文件中(test-adapter 和 docs)在基础镜像安装指令中保持了相同的依赖包列表
  • scow 文件中的基础镜像安装指令移除了不必要的依赖包

FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:ad1aedbcc1b0575074a91ac146d6956476c1f9985994810e4ee02efd932a68fd AS base

RUN apk update

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基础镜像安装指令移除了 libc6-compat python3 make gcc g++ git 等依赖包,需要确认这些包是否确实不需要。如果后续构建或运行需要这些包,可能会导致问题。

@renovate renovate bot changed the title chore(deps): update node.js to ad1aedb chore(deps): update node.js to 152270c May 17, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from b7ab6b1 to d78736f Compare May 17, 2025 03:46
Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 在三个Dockerfile文件中更新了Node.js基础镜像的sha256值
  • dev/test-adapter/Dockerfiledocker/Dockerfile.docs中保持相同的构建依赖安装命令
  • docker/Dockerfile.scow中移除了部分构建依赖的安装

FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:152270cd4bd094d216a84cbc3c5eb1791afb05af00b811e2f0f04bdc6c473602 AS base

RUN apk update

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

与其他两个Dockerfile相比,此文件移除了python3、make、gcc、g++和git的安装。这可能导致某些依赖这些工具的构建步骤失败,建议保持一致或明确说明原因。

Suggested change
RUN apk update
RUN apk update && apk add libc6-compat python3 make gcc g++ git

@renovate renovate bot changed the title chore(deps): update node.js to 152270c chore(deps): update node.js to 9f3ae04 May 24, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from d78736f to 98427a4 Compare May 24, 2025 15:35
@changeset-bot
Copy link

changeset-bot bot commented May 24, 2025

⚠️ No Changeset found

Latest commit: f17f1c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本次代码变更主要涉及以下内容:

  • 将三个Dockerfile中的基础镜像从node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944更新为node:22-alpine@sha256:9f3ae04faa4d2188825803bf890792f33cc39033c9241fc6bb201149470436ca
  • 更新了dev/test-adapter/Dockerfiledocker/Dockerfile.docs中的依赖安装命令
  • 简化了docker/Dockerfile.scow中的依赖安装部分

FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:9f3ae04faa4d2188825803bf890792f33cc39033c9241fc6bb201149470436ca AS base

RUN apk update

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

相比其他Dockerfile,这里缺少了必要的构建依赖安装(如python3、make、gcc等),可能导致构建失败或功能缺失。建议保持一致

Suggested change
RUN apk update
RUN apk update && apk add libc6-compat python3 make gcc g++ git

@renovate renovate bot changed the title chore(deps): update node.js to 9f3ae04 chore(deps): update node.js to 41e4389 May 31, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 98427a4 to 9e0953b Compare May 31, 2025 16:12
Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 更新了三个Dockerfile中node:22-alpine镜像的sha256哈希值
  • 在所有三个文件中, 将旧的镜像哈希9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944替换为新的41e4389f3d988d2ed55392df4db1420ad048ae53324a8e2b7c6d19508288107e
  • 分别在dev/test-adapter/Dockerfile和docker/Dockerfile.docs中保留了完整的依赖安装命令
  • 在docker/Dockerfile.scow中去除了部分依赖安装(python3 make gcc g++ git)

FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:41e4389f3d988d2ed55392df4db1420ad048ae53324a8e2b7c6d19508288107e AS base

RUN apk update

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移除了python3 make gcc g++ git等依赖安装,需要确认这些依赖是否真的不再需要,否则可能会导致构建失败或运行时问题。

@renovate renovate bot changed the title chore(deps): update node.js to 41e4389 chore(deps): update node.js to 5340cbf Jun 29, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 9e0953b to 4883fb2 Compare June 29, 2025 23:59
Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 三个Dockerfile中的基础镜像node:22-alpine的sha256摘要值发生了变更
  • 前两个Dockerfile中apk add命令安装的依赖项保持相同
  • 第三个Dockerfile.scow中移除了安装python3/make/gcc/g++/git的命令

FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:5340cbfc2df14331ab021555fdd9f83f072ce811488e705b0e736b11adeec4bb AS base

RUN apk update

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移除了python3/make/gcc/g++/git依赖的安装,请确认这是否会影响后续构建或运行时对相关工具的依赖需求

Suggested change
RUN apk update
RUN apk update && apk add libc6-compat python3 make gcc g++ git

@renovate renovate bot changed the title chore(deps): update node.js to 5340cbf chore(deps): update node.js to 10962e8 Jul 12, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 4883fb2 to 5c351d5 Compare July 12, 2025 12:04
Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本次代码变更主要涉及以下几点:

  • 更新了三处Dockerfile中使用的node:22-alpine基础镜像的sha256校验码



FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:10962e8568729b0cfd506170c5a2d1918a2c10ac08c0e6900180b4bac061adc9 AS base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

更新基础镜像的sha256校验码是为了修复安全漏洞还是版本升级?建议在提交信息中说明变更原因,以方便后续追踪。



FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:10962e8568729b0cfd506170c5a2d1918a2c10ac08c0e6900180b4bac061adc9 AS base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同问,这里sha256变更的原因是什么?如果是安全问题,建议列出具体漏洞信息。



FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:10962e8568729b0cfd506170c5a2d1918a2c10ac08c0e6900180b4bac061adc9 AS base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

与前面两处变更一致,但此Dockerfile中RUN指令只执行了apk update,与其他文件不同。应该保持一致性。

Suggested change
FROM node:22-alpine@sha256:10962e8568729b0cfd506170c5a2d1918a2c10ac08c0e6900180b4bac061adc9 AS base
RUN apk update && apk add libc6-compat python3 make gcc g++ git

@renovate renovate bot changed the title chore(deps): update node.js to 10962e8 chore(deps): update node.js to 5539840 Jul 21, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 5c351d5 to d1fb80b Compare July 21, 2025 07:00
@renovate renovate bot changed the title chore(deps): update node.js to 5539840 chore(deps): update node.js to 1b2479d Aug 4, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from d1fb80b to 65f9c5f Compare August 4, 2025 23:00
@renovate renovate bot changed the title chore(deps): update node.js to 1b2479d chore(deps): update node.js to d2166de Sep 1, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 65f9c5f to 57ba4ae Compare September 1, 2025 10:26
Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本次代码变更主要涉及以下内容:

  • 更新了三个 Dockerfile 文件中 node:22-alpine 基础镜像的 sha256 校验码
  • 新校验码为 d2166de198f26e17e5a442f537754dd616ab069c47cc57b889310a717e0abbf9
  • 两个 Dockerfile 保持了原有的依赖安装命令,一个删除了部分依赖



FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:d2166de198f26e17e5a442f537754dd616ab069c47cc57b889310a717e0abbf9 AS base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基础镜像的 sha256 校验码已更新,但缺少变更说明。建议在提交信息中说明镜像版本更新的具体原因或验证过程,确保镜像安全性。



FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:d2166de198f26e17e5a442f537754dd616ab069c47cc57b889310a717e0abbf9 AS base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档构建镜像也同样更新了校验码,但没有保持一致性的说明。建议添加注释说明为何需要进行此变更。



FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:d2166de198f26e17e5a442f537754dd616ab069c47cc57b889310a717e0abbf9 AS base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这次镜像更新移除了部分依赖包(python3 make gcc g++ git),但没有说明原因。如果是有意移除,建议添加注释说明。如有必要,应考虑此变更对其他构建步骤的影响。

@renovate renovate bot changed the title chore(deps): update node.js to d2166de chore(deps): update node.js to d2166de - autoclosed Sep 25, 2025
@renovate renovate bot closed this Sep 25, 2025
@renovate renovate bot deleted the renovate/node-22-alpine branch September 25, 2025 00:00
@renovate renovate bot changed the title chore(deps): update node.js to d2166de - autoclosed chore(deps): update node.js to d2166de Sep 27, 2025
@renovate renovate bot reopened this Sep 27, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 2a5dc00 to 57ba4ae Compare September 27, 2025 17:12
@renovate renovate bot changed the title chore(deps): update node.js to d2166de chore(deps): update node.js to cb31435 Sep 27, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 57ba4ae to dbd59c8 Compare September 27, 2025 20:33
@renovate renovate bot changed the title chore(deps): update node.js to cb31435 chore(deps): update node.js to dbcedd8 Oct 10, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from dbd59c8 to 7bd851f Compare October 10, 2025 03:53
@renovate renovate bot changed the title chore(deps): update node.js to dbcedd8 chore(deps): update node.js to bd26af0 Oct 23, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 7bd851f to 48ab16f Compare October 23, 2025 20:15
@renovate renovate bot changed the title chore(deps): update node.js to bd26af0 chore(deps): update node.js to b235848 Nov 2, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 48ab16f to 9ecc971 Compare November 2, 2025 07:33
@renovate renovate bot changed the title chore(deps): update node.js to b235848 chore(deps): update node.js to 9632533 Dec 5, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from 9ecc971 to ddc53ec Compare December 5, 2025 07:58
@renovate renovate bot changed the title chore(deps): update node.js to 9632533 chore(deps): update node.js to 9534949 Dec 18, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from ddc53ec to c46e100 Compare December 18, 2025 02:57
@renovate renovate bot changed the title chore(deps): update node.js to 9534949 chore(deps): update node.js to 0340fa6 Dec 18, 2025
@renovate renovate bot force-pushed the renovate/node-22-alpine branch from c46e100 to f17f1c5 Compare December 18, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code-ReviewRequested Code Review Requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant