-
Notifications
You must be signed in to change notification settings - Fork 662
[Others] Remove useless code and support FA3 in mixed #5404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Others] Remove useless code and support FA3 in mixed #5404
Conversation
|
Thanks for your contribution! |
| self.start_layer_index: int = fd_config.model_config.start_layer_index | ||
|
|
||
| if fd_config.parallel_config.expert_parallel_rank is None: | ||
| fd_config.parallel_config.expert_parallel_rank = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个变量我看这个文件没有用到?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5404 +/- ##
==========================================
Coverage ? 59.08%
==========================================
Files ? 327
Lines ? 40646
Branches ? 6171
==========================================
Hits ? 24017
Misses ? 14768
Partials ? 1861
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.