Skip to content

Conversation

@zhoutianzi666
Copy link
Collaborator

@zhoutianzi666 zhoutianzi666 commented Dec 5, 2025

Motivation

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

  • 支持FA3的mixed模式推理

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Dec 5, 2025

Thanks for your contribution!

@zhoutianzi666 zhoutianzi666 changed the title Remove useless code [Others] Remove useless code Dec 5, 2025
chang-wenbin
chang-wenbin previously approved these changes Dec 5, 2025
self.start_layer_index: int = fd_config.model_config.start_layer_index

if fd_config.parallel_config.expert_parallel_rank is None:
fd_config.parallel_config.expert_parallel_rank = 0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个变量我看这个文件没有用到?

lizhenyun01
lizhenyun01 previously approved these changes Dec 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@c45e064). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...el_executor/layers/attention/flash_attn_backend.py 0.00% 9 Missing ⚠️
...l_executor/layers/attention/append_attn_backend.py 50.00% 1 Missing ⚠️
...cutor/layers/attention/ops/pre_cache_len_concat.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5404   +/-   ##
==========================================
  Coverage           ?   59.08%           
==========================================
  Files              ?      327           
  Lines              ?    40646           
  Branches           ?     6171           
==========================================
  Hits               ?    24017           
  Misses             ?    14768           
  Partials           ?     1861           
Flag Coverage Δ
GPU 59.08% <8.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhoutianzi666 zhoutianzi666 merged commit 2aea8a3 into PaddlePaddle:develop Dec 8, 2025
22 of 26 checks passed
@zhoutianzi666 zhoutianzi666 changed the title [Others] Remove useless code [Others] Remove useless code and support FA3 in mixed Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants