Add the Vehicle interface to Nautilus #13474
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I create this, I become aware that the Vehicle interface is strange since almost all entities are rideable with commands. And there is an internal class called
VehicleEntitywhich is only applicable to boats and minecarts. Regardless of this oddity, to be consistent with the existing other uses of the Vehicle interface, I recommend it get added here.Other entities with the Vehicle Interface:
Main advantage to this change is access to events such as the following for API consistency till their use is deprecated.
Noting that many of the other "Vehicle" events are specific to boats/minecarts.