-
Notifications
You must be signed in to change notification settings - Fork 0
feature: 계좌 해지 및 자동이체 처리 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
try3982
wants to merge
6
commits into
dev
Choose a base branch
from
feat/account-tranfer
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
70e3874
feature: 계좌 해지 및 자동이체 처리
try3982 148c4a0
fix: 순환 참조(타 repository 사용) 제거
Paransaik 200794b
refactor: ErrorCode 추가
try3982 0b717ee
refactor: 리뷰 반영
try3982 88eab2e
refactor: 리뷰 반영
try3982 5d0b3c2
squash! refactor: 리뷰 반영 -. 필터검색을 dto로 만들어서 관리하도록 변경 -.validatePending…
try3982 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Empty file.
Binary file not shown.
Binary file not shown.
Empty file.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,7 @@ public void update(User user, Account account, CreateLoanRecord dto) { | |
| this.user = user; | ||
| this.account = account; | ||
| this.balance = dto.balance(); | ||
| // this.loanDate = LocalDateTime.now(); | ||
| this.loanDate = LocalDateTime.now(); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 자동정렬 안하신 것 같습니다. |
||
| this.delinquencyDate = dto.delinquencyDate(); | ||
| this.loanStatus = dto.loanStatus(); | ||
| this.loanType = dto.loanType(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 16 additions & 1 deletion
17
src/main/java/com/track/fin/record/DepositTransactionRecord.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 18 additions & 1 deletion
19
src/main/java/com/track/fin/record/TransferRequestRecord.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,29 @@ | ||
| package com.track.fin.record; | ||
|
|
||
| import com.track.fin.type.TransactionMethodType; | ||
| import jakarta.validation.constraints.*; | ||
|
|
||
| public record TransferRequestRecord( | ||
|
|
||
| @NotNull | ||
| @Min(1) | ||
| Long userId, | ||
|
|
||
| @NotBlank | ||
| @Size(min = 10, max = 10) | ||
| String fromAccountNumber, | ||
|
|
||
| @NotBlank | ||
| @Size(min = 10, max = 10) | ||
| String toAccountNumber, | ||
| Long amount | ||
|
|
||
| @NotNull | ||
| @Min(10) | ||
| @Max(1_000_000_000) | ||
| Long amount, | ||
|
|
||
| @NotNull | ||
| TransactionMethodType transactionMethodType | ||
| ) { | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ModelAttribute로 TransferSearchRequestRecord를 받으셨는데, 사용은 안하시네요? 필터 비지니스 로직이 들어가야하지 않나요?
DTO를 2개 못 받으셔서 ModelAttribute로 받으신 거 같은데, TransferRequestRecord 하나의 DTO에 filter 조건도 한번에 받으시면 안되시는 건가요?