Enhance Chat Display Logic and Enforce Report Restrictions #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevents banned users from reporting messages and disallows reporting messages from admins or room owners. - Introduces a dependency on `RoomService` to verify user privileges and enforces stricter validation for reporting logic.
- Optimizes the retrieval of user display names by handling only two users per direct chat. - Adds fallback names for unknown users and ensures the current user is always second in the order. - Enhances clarity and consistency in user identification for direct chats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the
DirectChatRepositoryandModerationServiceto improve functionality and enforce stricter validation rules. The key changes include refactoring the logic for fetching user display names in direct chats, adding a new dependency to theModerationService, and implementing additional checks for reporting messages.Updates to
DirectChatRepository:Updates to
ModerationService:roomService, toModerationServiceto enable room-related operations. [1] [2]ReportMessagemethod to include: