Production #43
Merged
Production #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the background gradient for a smoother visual - Reorganized text alignment for better readability - Added hover effects for interactive feedback
- Added subtle animations to enhance user engagement - Improved responsive layout for better display on all screen sizes - Adjusted color scheme for better visual consistency and contrast
Adjust on landing page visuals and responsiveness
- Changed header color palette to match new design - Added hover transitions for interactive elements
update header colors and add hover effects
Adjust on footer
Fixing pipelines placeholders
add middleware, add axios, add register and add login
Fix CD and add backend conections
add websockets and create rooms
Add login with google and direct chats
fixing images in profile and add aside room
fix google users
add user banned feature
add names in dashboard chats
fixing before deploying
There was a problem hiding this comment.
Pull Request Overview
This PR introduces significant improvements to CI/CD workflows by integrating Firebase environment variables into Docker builds, refines Docker configurations for production and local development, and updates the authentication forms for enhanced usability.
- CI/CD: Firebase build arguments have been added to both master and develop workflows to ensure proper environment variable injection.
- Docker: Separate Dockerfiles for production and local environments have been created and updated.
- Authentication & UI: Login/registration forms (both mobile and desktop) have been updated and integrated with Google authentication, with several UI and code refactoring improvements across various components.
Reviewed Changes
Copilot reviewed 64 out of 72 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added dependencies needed for Firebase, React Query, Toast notifications, etc. |
| .github/workflows/*.yml | Updated Docker build commands to include Firebase build arguments and updated deploy steps. |
| Dockerfile.prod / Dockerfile.local | Refactored Docker configurations for improved consistency and environment variable management. |
| app/(auth)/login/_components/MobileForm.tsx | Updated mobile authentication forms; minor spelling and label inconsistencies noted. |
| app/(protected)/dashboard/_components/RoomList.tsx | Refactored UI components; commented code blocks exist that could be removed for clarity. |
Comments suppressed due to low confidence (1)
app/(auth)/login/_components/MobileForm.tsx:6
- The label for the username field contains a spelling error ('Tu ususuario'); please change it to 'Tu usuario' for clarity and consistency with other forms.
registerAction: (payload: FormData) => void;
Comment on lines
+35
to
+48
| {/* <div className="flex gap-5 justify-end flex-2/12"> | ||
| {CanExitRoom(sala) && ( | ||
| <Tooltip title="Salir de la sala" placement="top"> | ||
| <button className="bg-purple rounded-full"> | ||
| <CancelIcon className="w-10 h-10 cursor-pointer" />{' '} | ||
| </button> | ||
| </Tooltip> | ||
| )} | ||
| <Tooltip title="Notificaciones" placement="top"> | ||
| <button className="bg-purple rounded-full"> | ||
| <DoorBellIcon className="w-10 h-10 cursor-pointer" />{' '} | ||
| </button> | ||
| </Tooltip> | ||
| </div> | ||
| </div> */} |
There was a problem hiding this comment.
[nitpick] There is a large commented-out block of code in RoomList.tsx related to exit buttons and notifications. If this code is no longer needed, consider removing it to improve maintainability and reduce clutter.
LifeRIP
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the CI/CD workflows, Docker configurations, and authentication forms. Key changes include adding Firebase-related build arguments to Docker workflows, enhancing the Docker setup for both local and production environments, and updating the login and registration forms for better usability and functionality.
CI/CD Workflow Enhancements:
.github/workflows/develop-CD.ymland.github/workflows/master-CD.ymlto include Firebase-related build arguments in the Docker image build process. This ensures environment variables are properly injected during the build. [1] [2].envfiles on the GCP VM with the new Docker image references for both development and production workflows. [1] [2]docker pullanddocker compose downcommands. [1] [2]Docker Configuration Improvements:
Dockerfile.localfor local development, exposing port 3000 and running the app in development mode.Dockerfile.prodto include Firebase environment variables as build arguments and set them as runtime environment variables, ensuring proper configuration for production builds.Authentication Form Updates:
LoginGestpage with updated login and registration forms for both desktop (DesktopForm.tsx) and mobile (MobileForm.tsx) views. These forms now support actions for login and registration, integrate with aGoogleLoginButtoncomponent, and include aSubmitButtonwith loading states. [1] [2]nameattributes to input fields in both forms to align with form handling best practices. [1] [2]Miscellaneous Changes:
.dockerignoreto includenode_modules, ensuring it is ignored during Docker builds.