Optimize NIF parsing: reduce allocations, fix cross-platform builds #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified and fixed performance bottlenecks and platform compatibility issues in NIF file parsing.
Build Fixes
NIFORGE_APImacro (added GCC__attribute__((visibility))for non-Windows)#pragma oncefrom.cppfile<cmath>,<cstring>includesPerformance Optimizations
String handling - Eliminated allocations in hot paths:
Vector operations:
blocks.reserve(header.numBlocks)before parsing loopemplace_back()instead ofpush_back()for 10+ constructor calls (NiNode, NiMesh, NiHeader, etc.)NiHeaderusedcapacity()in loop condition instead of actual countType correctness:
uint16_t,uint32_t) matching NIF specdynamic_pointer_castwith directdynamic_castin parseDataStreamsMove semantics - Added
noexceptto move ops (NiFile, NiDataStream) for container optimizationConst correctness -
getBlocksOfType()andgetRootNodes()now const-qualifiedExample Impact
Factory lookup no longer allocates/copies strings for each of the ~100 blocks in a typical NIF file. Vector reservations eliminate 3-4 reallocations per parsing pass.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.