Adds afterTagSave callback to set tag classes properly. #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the colour of tags by setting a class did not work when tags were unchanged after editing ended with the separator, because in that case the DOM element was recreated, but no change event was fired since the tags were unchanged. IMO, not firing a change event when tags are unchanged is correct, so onChange is not suitable for adding classes to tags. Therefore, I added an afterTagSave callback that receives the DOM element of the saved tag, which makes it easier to add custom CSS classes. The demo has been updated accordingly.