Skip to content

first commit #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shivammaniharsahu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

first commit #10

shivammaniharsahu wants to merge 3 commits into from

Conversation

@shivammaniharsahu
Copy link

@shivammaniharsahu shivammaniharsahu commented Oct 12, 2019

binary search operation

@Prime-5
Copy link
Owner

Prime-5 commented Oct 13, 2019

Hey @shivammaniharsahu Thanks for the PR.
I would gladly accept the binary search one, but I can't accept the swap one (it is already present in "01. trivial (addition).cpp"

Prime-5
Prime-5 approved these changes Oct 13, 2019
View reviewed changes
Copy link
Owner

@Prime-5 Prime-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@Prime-5
Copy link
Owner

Prime-5 commented Oct 13, 2019

I can't merge the first one without mergin the second. If you could revert your second commit, I would gladly accept the first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prime-5 Prime-5 Prime-5 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivammaniharsahu @Prime-5