add job submition dependency option

[mathieudpnt]

I added the possiblity to run a job instance after another job is finished
This can be used either using a string corresponding to the first job id or another Job instance

job_1 = Job(...)
job_1.name = "DavidGoodEnough"
job_1.submit_pbs()

job_2 = Job(...)
job_2.submit_pbs(depend_on="DavidGoodEnough")

job_1 = Job(...)
job_1.submit_pbs()

job_2 = Job(...)
job_2.submit_pbs(depend_on=job_1)

Note:
Static method _build_dependency_string from Job class implement by default "afterok" dependency but other dependecies have already been implemented altough they are not used yet

[Gautzilla]

I feel like the _build_dependency_string method could be way lighter, e.g.:

    @staticmethod
    def _build_dependency_string(
        depend_on: Job | list[Job] | str | list[str],
        dependency_type: str = "afterok",
    ) -> str:
        depend_on = depend_on if isinstance(depend_on, list) else [depend_on]
        if job := next(
            (j for j in depend_on if isinstance(j, Job) and not j.job_id),
            None,
        ):
            msg = f"Job '{job.name}' has not been submitted yet."
            raise ValueError(msg)
        return f"{dependency_type}:" + ":".join(
            dependency.job_id if type(dependency) is Job else dependency
            for dependency in depend_on
        )

or, with my comment below about the status check rather than job_id:

    @staticmethod
    def _build_dependency_string(
        depend_on: Job | list[Job] | str | list[str],
        dependency_type: str = "afterok",
    ) -> str:
        depend_on = depend_on if isinstance(depend_on, list) else [depend_on]
        if job := next(
            (j for j in depend_on if isinstance(j, Job) and j.status.value < JobStatus.QUEUED.value),
            None,
        ):
            msg = f"Job '{job.name}' has not been submitted yet."
            raise ValueError(msg)
        return f"{dependency_type}:" + ":".join(
            dependency.job_id if type(dependency) is Job else dependency
            for dependency in depend_on
        )

And, if the check for f{dependency_type}: is really needed (see my comment on the corresponding test below), you can still filter it with something like:

    @staticmethod
    def _build_dependency_string(
        depend_on: Job | list[Job] | str | list[str],
        dependency_type: str = "afterok",
    ) -> str:
        depend_on = depend_on if isinstance(depend_on, list) else [depend_on]
        depend_on = [
            dependency.lstrip(f"{dependency_type}:")
            if isinstance(dependency, str)
            else dependency
            for dependency in depend_on
        ]
        if job := next(
            (
                j
                for j in depend_on
                if isinstance(j, Job) and j.status.value < JobStatus.QUEUED.value
            ),
            None,
        ):
            msg = f"Job '{job.name}' has not been submitted yet."
            raise ValueError(msg)
        return f"{dependency_type}:" + ":".join(
            dependency.job_id if type(dependency) is Job else dependency
            for dependency in depend_on
        )

but it already starts to be messy again and I think I'd use a proper helper method to set the depend_on list up 🥸🥸.

Also, all your tests could higlhy benefit from parametrizing, you have lots of repeated code chunks!

[mathieudpnt]

I tried to make better tests, let me know your thoughts @Gautzilla

[mathieudpnt]