-
Notifications
You must be signed in to change notification settings - Fork 0
🧑💻 天使がスペクテイターを対象に行動を行わないように #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies spectator handling for mob interactions to prevent angels from targeting spectator players. The changes add spectator checks and adjust player targeting to exclude spectators from mob abilities and interactions.
- Adds
tag=!PlayerShouldInvulnerableandgamemode=!spectatorfilters to mob targeting - Updates sound effects from global targeting to per-player execution
- Refines tag removal operations to be more selective
Reviewed Changes
Copilot reviewed 298 out of 391 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Various mob tick functions | Add spectator exclusions to targeting and player detection |
| Sound effect implementations | Change from global @a to per-player @s sound execution |
| Tag cleanup functions | Add specificity to tag removal operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...t/functions/mob/1004.tultaria/tick/skill/thunder/lightning_stab/hyper_stab/damage.mcfunction
Show resolved
Hide resolved
...tions/mob/1004.tultaria/tick/skill/thunder/lightning_stab/chain_lightning/strong/.mcfunction
Show resolved
Hide resolved
Asset/data/asset/functions/mob/1004.tultaria/tick/skill/fire/blazing_slash/slash.mcfunction
Show resolved
Hide resolved
Asset/data/asset/functions/mob/0429.killer_bee_formation/tick/.mcfunction
Outdated
Show resolved
Hide resolved
424e819 to
4249c35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 298 out of 391 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.