Skip to content

Conversation

@mateusnroll
Copy link

Since Trello added the ellipsis button to the right, the list total was breaking to the second line.
screen shot 2016-04-11 at 9 59 04 pm

This makes it absolute positioned and hence fixes the issue – I hope :). It fixes #97. The updated build looks like this:
screen shot 2016-04-11 at 10 04 55 pm

I went with the absolute positioning because:

  1. It will be less likely to break something they introduce. The alternate approach would be to change the .list-header to a flex container, which means messing with Trello's CSS – I guess it's not something I should be doing unless necessary.
  2. The ellipsis button is already using absolute positioning, so why not?
  3. Changing to a flex container would break the card count, this does not.

I hope this helps 👍

Mateus Pinheiro added 2 commits April 11, 2016 22:06
Since Trello added the ellipsis button to the right, the list total was
breaking to the second line. This makes it absolute positioned and
hence fixes the issue – I hope :)
Since fixing the column totals makes them absolute, it also affected
the board total. This makes the board totals not break.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken list count

1 participant