Skip to content

Conversation

@dastansam
Copy link
Contributor

@dastansam dastansam commented Dec 8, 2025

This PR does mainly two things:

  • Get rid of balances pallet fork and consolidate proofs in the wormhole pallet instead. Proofs, transfer count, and nullifiers all are now stored in the wormhole pallet.
  • Add new wormhole proof recorder transaction extension that intercepts successful (post-dispatch) asset and native token transfers and records their transfer proof. Similar to reversible transactions extension except for post dispatch nature. Additionally, there are two new extrinsics in the wormhole pallet for native and asset transfers (they won't be intercepted by the tx extension)

@dastansam dastansam changed the base branch from main to wormhole December 8, 2025 13:35
}

#[test]
fn test_wormhole_transfer_proof_generation() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we lose this test entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's back in later commits

@illuzen
Copy link
Contributor

illuzen commented Dec 11, 2025

overall LGTM, can we go back to having descriptions on PRs? Maybe just make them like one paragraph

@dastansam dastansam marked this pull request as ready for review December 11, 2025 13:17
@dastansam dastansam self-assigned this Dec 11, 2025
@dastansam dastansam changed the title Feat/use canonical balances and add wormhole assets Use canonical balances pallet and add support for assets in wormhole Dec 11, 2025
Copy link
Contributor

@ethan-crypto ethan-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy to help here https://github.com/Quantus-Network/qp-zk-circuits/pull/55/changes to get the entire proving and verification flow working end 2 end ASAP.

Copy link
Collaborator

@czareko czareko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the wormhole branch first, and then add here only the changes you actually need.

@dastansam dastansam requested a review from czareko December 14, 2025 15:37
@czareko czareko mentioned this pull request Dec 22, 2025
@czareko czareko merged commit cd916c2 into wormhole Dec 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants