-
Notifications
You must be signed in to change notification settings - Fork 6
Use canonical balances pallet and add support for assets in wormhole #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use canonical balances pallet and add support for assets in wormhole #333
Conversation
…-canonical-balances-and-add-wormhole-assets
| } | ||
|
|
||
| #[test] | ||
| fn test_wormhole_transfer_proof_generation() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we lose this test entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it's back in later commits
|
overall LGTM, can we go back to having descriptions on PRs? Maybe just make them like one paragraph |
ethan-crypto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Happy to help here https://github.com/Quantus-Network/qp-zk-circuits/pull/55/changes to get the entire proving and verification flow working end 2 end ASAP.
czareko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the wormhole branch first, and then add here only the changes you actually need.
…/use-canonical-balances-and-add-wormhole-assets
This PR does mainly two things: