Enforce miner wormhole address #344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* exponentially decaying token rewards * script to simulate emissions * clean up constants and switch python script to rust test * log if we hit max supply somehow
* exponentially decaying token rewards * script to simulate emissions * clean up constants and switch python script to rust test * log if we hit max supply somehow
…hain into illuzen/miner-wormhole
Contributor
Author
|
ah looks like we got the decaying rewards in here too...maybe it's ok? |
dastansam
reviewed
Dec 23, 2025
| traits::{AccountIdConversion, Saturating}, | ||
| }; | ||
|
|
||
| const UNIT: u128 = 1_000_000_000_000u128; |
Contributor
There was a problem hiding this comment.
we can pass this from the runtime as part of the Config as a constant. otherwise, duplicate definition
Comment on lines
+140
to
+157
| // Log readable amounts (convert to tokens by dividing by 1e12) | ||
| if let (Ok(total), Ok(treasury), Ok(miner_amt), Ok(current), Ok(fees)) = ( | ||
| TryInto::<u128>::try_into(total_reward), | ||
| TryInto::<u128>::try_into(treasury_reward), | ||
| TryInto::<u128>::try_into(miner_reward), | ||
| TryInto::<u128>::try_into(current_supply), | ||
| TryInto::<u128>::try_into(tx_fees), | ||
| ) { | ||
| let remaining: u128 = | ||
| TryInto::<u128>::try_into(max_supply.saturating_sub(current_supply)) | ||
| .unwrap_or(0); | ||
| log::debug!(target: "mining-rewards", "💰 Total reward: {:.6}", total as f64 / UNIT as f64); | ||
| log::debug!(target: "mining-rewards", "💰 Treasury reward: {:.6}", treasury as f64 / UNIT as f64); | ||
| log::debug!(target: "mining-rewards", "💰 Miner reward: {:.6}", miner_amt as f64 / UNIT as f64); | ||
| log::debug!(target: "mining-rewards", "💰 Current supply: {:.2}", current as f64 / UNIT as f64); | ||
| log::debug!(target: "mining-rewards", "💰 Remaining supply: {:.2}", remaining as f64 / UNIT as f64); | ||
| log::debug!(target: "mining-rewards", "💰 Transaction fees: {:.6}", fees as f64 / UNIT as f64); | ||
| } |
Contributor
There was a problem hiding this comment.
is it possible to not have these lines? or at least have it as a single debug print call? it adds almost 20 lines of code just to print a debug log
Comment on lines
+131
to
+132
| let treasury_reward = | ||
| total_reward.saturating_mul(treasury_portion.into()) / 100u32.into(); |
Contributor
There was a problem hiding this comment.
if we use Permill or Perbill we wouldn't need to have this division here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not involve meaningful change to the block header. Instead, we reinterpret the 32 byte accountid as the wormhole address preimage and send rewards there.
Also deleted the redundant and outdated mining info in the readme and updated mining.md