Auth time fix #342
Merged
Auth time fix #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure auth time defaults to 1 minute, and have one source of truth. Fixes a bug where auth time display was incorrect when first enabling auth.
dewabisma
reviewed
Dec 17, 2025
| } | ||
|
|
||
| // this feels wrong. One bug is it will count from last authenticated time, so if I run the app for 1 minute, then | ||
| // go away to another app, then come back immediately, it will require auth. |
Collaborator
There was a problem hiding this comment.
I don't really get what you mean by this bug. Because lock behavior is exactly when we move from app to other app it should lock.
dewabisma
reviewed
Dec 17, 2025
dewabisma
reviewed
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure auth time defaults to 1 minute, and have one source of truth. Fixes a bug where auth time display was incorrect when first enabling auth.