Quantus raid quest

[dewabisma]

Summary

• Refactor quests into multiple screens
• Add raid quest form sheet
• Add raid quest screen

Screenshots

• New quests screen

• Unlinked X raid quest state

• No active raid quest state

• Raid quests screen on empty submission (just removed submission)

• Raid submission sheet

• Raid submission input error

[n13]

I checked in some changes

PR Review Summary: Quantus Raid Quest (PR #344)

Overview

I have performed a thorough review of the "Quantus raid quest" PR. The PR implements new quest screens, a raid submission form, and integrates with the TaskmasterService.

Key Findings

1. Usability Improvement (Regex Validation)

Issue: The initial regex for validating raid submission URLs only supported x.com links.
Impact: Users frequently copy links from the Twitter mobile app or legacy URLs, which often appear as twitter.com or mobile.twitter.com. These valid submissions would have been rejected.
Fix: Updated the regex to support:

• x.com and twitter.com domains.
• www. and mobile. subdomains.
• Optional query parameters.

2. Code Quality & Testability

Refactoring:

• Extracted the validation logic from the UI widget RaidSubmissionActionSheet into a reusable and testable utility class Validators (mobile-app/lib/utils/validators.dart).
• This adheres to the separation of concerns principle and makes the logic unit-testable.

Testing:

• Added a comprehensive unit test suite in mobile-app/test/unit/validators_test.dart.
• The tests cover various valid edge cases (e.g., mobile links, query parameters) and invalid inputs.
• Status: All tests passed.

3. Architecture

• The separation of quest screens (KingOfTheRaiderScreen, KingOfTheShillScreen) is clean and follows the existing project structure.
• Service integration with TaskmasterService appears correct.

Actions Taken

• Refactored validation logic to Validators class.
• Updated RaidSubmissionActionSheet to use the new Validators class.
• Added unit tests for URL validation.
• Verified tests pass locally.

Conclusion

The PR is robust and ready for merging. The addition of unit tests and improved regex handling ensures a better user experience and maintainable code.