-
Notifications
You must be signed in to change notification settings - Fork 1
[Draft] Separate Survey logic to separate package for reusability #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
It would definitely help to separate all the Survey package stuff into a separate commit so I can review it easier. The difference in our linter settings is making it hard to see the actual changes. |
9ca4f62 to
1d157c8
Compare
|
@RISCfuture Updated the branch without my custom linting. Now you should be able to see the real diff. |
| "cldr-data": "^36.0.0", | ||
| "cldrjs": "^0.5.1", | ||
| "core-js": "^3.6.5", | ||
| "i-just-crashed-my-plane-survey": "^0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why its not diffing correctly but the difference here is the new dependency on survey package
|
Thanks. I will need to check out the project and make sure it still deploys properly to the Finally, we'll need a better NPM package name than |
4e10799 to
4ea459c
Compare
33d6235 to
d9d0cbb
Compare
9a46d38 to
88e1cba
Compare
780b544 to
bd62cc7
Compare
98eb55b to
eee3509
Compare
626100c to
231beab
Compare
b58fc7c to
008473a
Compare
c932b6d to
4b3724b
Compare
6bb623c to
a5c3d2f
Compare
Hey Tim,
Thanks for creating this. I like the way how you structured the Survey logic and made it easy to extend. I’m playing with React Native and wanted to consume the survey logic in it. Currently the repo is structured with both the web and survey part together. I was thinking of separating it out into two packages so that Survey can be published as NPM package independently.
I made the change to leverage Lerna for that. The PR is just a draft and still needs work to be able to merge. But I wanted to discuss this with you before making anymore changes to it. Let me know what you think or if you have an alternative approach in mind?
.DS_Storefiles*I might be missing something here :)