Cleaned ollama container moving the model download to docker #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilMM27
requested changes
Dec 2, 2025
Contributor
GilMM27
left a comment
GilMM27
left a comment
There was a problem hiding this comment.
please test and add the missing changes ;)
GilMM27
reviewed
Dec 4, 2025
Contributor
GilMM27
left a comment
GilMM27
left a comment
There was a problem hiding this comment.
before approving please submit evidence this was tested
|
|
||
| # Download model and Modelfile to the directory where this script is located | ||
| SCRIPT_DIR=$(dirname "$(readlink -f "$0")") | ||
| SCRIPT_DIR="$(cd "$(dirname "$0")/../../../hri/packages/nlp/assets" && pwd)" |
Contributor
There was a problem hiding this comment.
nit: in my opinion it would be simpler to just write the relative path
| network_mode: host | ||
| volumes: | ||
| - ../../../hri/packages/nlp/assets:/ollama | ||
| - ../scripts/ollama:/scripts |
Contributor
There was a problem hiding this comment.
I'm not sure whats the better call here, if just copying the file (like in the dockerfile of display) or creating this volume. I'll let you decide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved download model logic (the .sh) to docker folder, updated docker configuration and gitignore. should work