Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Apr 18, 2023

Proposed changes (including videos or screenshots)

We're extracting the service creation from PR #27024 in worder to facilitate reviews and discussions.

Here we're just introducing the new services; the adoption of those services is mostly intended to change in future PRs

Issue(s)

Steps to test or reproduce

Further comments

AECO-119

@d-gubert d-gubert added this to the 6.2.0 milestone Apr 18, 2023
@d-gubert d-gubert force-pushed the feat/apps-engine-services branch from a478f56 to 68f4d71 Compare April 19, 2023 20:07
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.43%. Comparing base (6bcdd88) to head (fccb9cf).
Report is 2122 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28964      +/-   ##
===========================================
- Coverage    48.51%   48.43%   -0.08%     
===========================================
  Files          697      697              
  Lines        13913    13913              
  Branches      2447     2447              
===========================================
- Hits          6750     6739      -11     
- Misses        6787     6792       +5     
- Partials       376      382       +6     
Flag Coverage Δ
e2e 46.53% <ø> (-0.08%) ⬇️
unit 64.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert requested review from a team and tapiarafael April 20, 2023 13:44
@d-gubert d-gubert marked this pull request as ready for review April 20, 2023 13:44
tapiarafael
tapiarafael previously approved these changes Apr 20, 2023
@d-gubert d-gubert removed this from the 6.2.0 milestone May 8, 2023
@tapiarafael tapiarafael requested a review from a team as a code owner May 31, 2023 18:07
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

⚠️ No Changeset found

Latest commit: fccb9cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert d-gubert added the feat: Apps-Engine MS Moving the Apps-Engine to Microservices label Jun 28, 2023
@pierre-lehnen-rc
Copy link
Contributor

What's the criteria for splitting something into a separate service or not?
I'm just curious why the videoconf methods are on their own service, but the slash commands stuff remain on the AppManager.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ d-gubert
❌ Rafael Tapia


Rafael Tapia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: Apps-Engine MS Moving the Apps-Engine to Microservices stat: conflict

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants