fix: transfer room fails without error feedback

apps/meteor/app/livechat/server/lib/Helper.ts

@@ -505,14 +505,8 @@ export const forwardRoomToAgent = async (room: IOmnichannelRoom, transferData: T
 	// There are some Enterprise features that may interrupt the forwarding process
 	// Due to that we need to check whether the agent has been changed or not
 	logger.debug(`Forwarding inquiry ${inquiry._id} to agent ${agent.agentId}`);
-	const roomTaken = await RoutingManager.takeInquiry(
-		inquiry,
-		agent,
-		{
-			...(clientAction && { clientAction }),
-		},
-		room,
-	);
+	const options = typeof clientAction !== 'undefined' ? { clientAction } : undefined;
+	const roomTaken = await RoutingManager.takeInquiry(inquiry, agent, options, room);
 	if (!roomTaken) {
 		logger.debug(`Cannot forward inquiry ${inquiry._id}`);
 		return false;

apps/meteor/app/livechat/server/lib/RoutingManager.ts

@@ -60,7 +60,7 @@ type Routing = {
 			'estimatedInactivityCloseTimeAt' | 'message' | 't' | 'source' | 'estimatedWaitingTimeQueue' | 'priorityWeight' | '_updatedAt'
 		>,
 		agent: SelectedAgent | null,
-		options: { clientAction?: boolean; forwardingToDepartment?: { oldDepartmentId?: string; transferData?: any } },
+		options: { clientAction?: boolean; forwardingToDepartment?: { oldDepartmentId?: string; transferData?: any } } | undefined,
 		room: IOmnichannelRoom,
 	): Promise<IOmnichannelRoom | null | void>;
 	transferRoom(room: IOmnichannelRoom, guest: ILivechatVisitor, transferData: TransferData): Promise<boolean>;
@@ -266,7 +266,12 @@ export const RoutingManager: Routing = {
 				inquiry,
 				options,
 			});
-			return cbRoom;
+
+			if (cbRoom && cbRoom.chatQueued) {
+				return cbRoom;
+			}
+
+			return;
 		}
 
 		const result = await LivechatInquiry.takeInquiry(_id, inquiry.lockedAt);