-
Notifications
You must be signed in to change notification settings - Fork 12.9k
fix: prevent admin workspace page from failing when instances.get errors #38046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: prevent admin workspace page from failing when instances.get errors #38046
Conversation
|
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Warning Rate limit exceeded@sahillllllllll-bit has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 18 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdded conditional inline styling to RoomMessage to highlight messages authored by the current user, and adjusted useWorkspaceInfo's instances query to disable retries and prevent thrown errors (by setting Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/meteor/client/components/message/variants/RoomMessage.tsx (1)
69-98: Unrelated changes: Remove message styling from this PR.The RoomMessage component changes add conditional styling for messages authored by the current user, but this is completely unrelated to the PR's stated objective of "preventing admin workspace page from failing when instances.get errors."
The PR objectives, title, and linked issue (#38045) all focus exclusively on the Admin → Workspace page (/admin/info) and the instances.get API failure. These message styling changes:
- Affect the chat message UI, not the admin workspace page
- Are not mentioned anywhere in the PR description or objectives
- Introduce unnecessary risk by bundling unrelated features
Please move these styling changes to a separate PR focused on chat message UX improvements.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
apps/meteor/client/components/message/variants/RoomMessage.tsxapps/meteor/client/hooks/useWorkspaceInfo.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/hooks/useWorkspaceInfo.tsapps/meteor/client/components/message/variants/RoomMessage.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
e20aafc to
a4dacb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
apps/meteor/client/components/message/variants/RoomMessage.tsxapps/meteor/client/hooks/useWorkspaceInfo.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/meteor/client/hooks/useWorkspaceInfo.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/components/message/variants/RoomMessage.tsx
Proposed changes (including videos or screenshots)
This PR fixes an issue where the Admin → Workspace page (
/admin/info) fails completely when theGET /api/v1/instances.getrequest returns an error.Previously, if the instances endpoint failed (for example, in local, development, or self-hosted setups),
the entire Workspace page showed a generic “Error loading pages” message, even though other required
admin APIs were responding successfully.
With this change, failures from
instances.getare handled in isolation so the rest of the Workspacepage continues to render normally. When instance data cannot be loaded, the UI degrades gracefully
instead of failing the entire page.
This is a frontend-only change and does not modify backend behavior or API contracts.
Screenshots
Workspace page loading successfully when
instances.getfails (after fix):Network tab showing failed
instances.getrequest while other admin APIs succeed:Issue(s)
Closes #38045
Steps to test or reproduce
/admin/info)Expected result
Further comments
This change improves error isolation and robustness of the Admin Workspace page by ensuring that a
single non-critical endpoint failure does not cause a full page failure. The approach keeps the fix
minimal and scoped to frontend error handling only.
Summary by CodeRabbit
Style
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.