fix(a11y): add dev warning for buttons missing accessible names #1811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds a non-breaking accessibility check to the
Buttoncomponent that warns developers when a button is visually "empty" (icon-only, loading-only, or square) and lacks an ARIA label.Why is this needed?
To ensure WCAG 2.1 compliance. Icon-only buttons are unusable for screen reader users unless an
aria-labelis provided. This warning helps developers catch these omissions during development.Changes
Button.tsxto includeChildrenfrom React.console.warnwrapped in a production-environment check.Testing
<Button icon="edit" />-> Console should show warning.<Button icon="edit" aria-label="Edit" />-> No warning.<Button>Save</Button>-> No warning.closes #1810