Skip to content

Conversation

@Vrund4591
Copy link

Closes #1305

Description

The MultiSelect dropdown was failing to close when clicking the addon icon (chevron) because the click event was bubbling up to the container, causing the menu to immediately re-open.

This PR fixes the issue by:

  1. Adding e.stopPropagation() to the SelectAddon click handler to stop the event bubbling.
  2. Adding onMouseDown={(e) => e.preventDefault()} to prevent focus loss (blur) which was causing conflicting toggle states.

Changes

  • Added handleAddonClick handler to MultiSelect.tsx.
  • Applied onMouseDown prevention to SelectAddon.

Verification

  1. Open Storybook > MultiSelect > Default.
  2. Click the input to open the dropdown.
  3. Click the chevron icon.
  4. Validated that the dropdown now closes correctly without bouncing back open.

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2026

🦋 Changeset detected

Latest commit: a82cf4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Dropdown for adding roles during new member addition does not close when the up/down icon is clicked.

2 participants