fix(fuselage): ensure MultiSelect dropdown closes on addon click #1816
+14
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1305
Description
The
MultiSelectdropdown was failing to close when clicking the addon icon (chevron) because the click event was bubbling up to the container, causing the menu to immediately re-open.This PR fixes the issue by:
e.stopPropagation()to theSelectAddonclick handler to stop the event bubbling.onMouseDown={(e) => e.preventDefault()}to prevent focus loss (blur) which was causing conflicting toggle states.Changes
handleAddonClickhandler toMultiSelect.tsx.onMouseDownprevention toSelectAddon.Verification