Skip to content

Remove stale comments #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yara-blue merged 1 commit into from
Nov 25, 2025
+0 −42
Merged

Remove stale comments #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions src/mixer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,35 +110,6 @@ impl Source for MixerSource {
Err(SeekError::NotSupported {
underlying_source: std::any::type_name::<Self>(),
})

// uncomment when #510 is implemented (query position of playback)

// let mut org_positions = Vec::with_capacity(self.current_sources.len());
// let mut encounterd_err = None;
//
// for source in &mut self.current_sources {
// let pos = /* source.playback_pos() */ todo!();
// if let Err(e) = source.try_seek(pos) {
// encounterd_err = Some(e);
// break;
// } else {
// // store pos in case we need to roll back
// org_positions.push(pos);
// }
// }
//
// if let Some(e) = encounterd_err {
// // rollback seeks that happend before err
// for (pos, source) in org_positions
// .into_iter()
// .zip(self.current_sources.iter_mut())
// {
// source.try_seek(pos)?;
// }
// Err(e)
// } else {
// Ok(())
// }
}
}

Expand Down
13 changes: 0 additions & 13 deletions src/source/mix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,18 +117,5 @@ where
Err(SeekError::NotSupported {
underlying_source: std::any::type_name::<Self>(),
})

// uncomment when #510 is implemented (query position of playback)
// TODO use source_intact to check if rollback makes sense

// let org_pos = self.input1.playback_pos();
// self.input1.try_seek(pos)?;
//
// let res = self.input2.try_seek(pos);
// if res.is_err() { // rollback seek in input1
// self.input1.try_seek(org_pos)?;
// }
//
// res
}
}