Replace ConstChoice with ctutils::Choice
#1035
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
- Coverage 79.23% 79.13% -0.10%
==========================================
Files 164 165 +1
Lines 17707 17616 -91
==========================================
- Hits 14030 13941 -89
+ Misses 3677 3675 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tarcieri
force-pushed
the
replace-constchoice-with-ctutils-choice
branch
6 times, most recently
from
fb13ecd to
9869e41
Compare
Depends on RustCrypto/utils#1266 Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`.
tarcieri
force-pushed
the
replace-constchoice-with-ctutils-choice
branch
from
9869e41 to
275cca2
Compare
tarcieri
changed the title
ConstChoice with ctutils::ChoiceConstChoice with ctutils::Choice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on RustCrypto/utils#1266
Extracts all of the
const fnconstructor and predication/selection methods used bycrypto-bigintinto thectutilscrate, allowing theConstChoicetype to be removed and replaced byctutils::Choice.