Skip to content

bug fixes realated to indexes in ack and nack handling #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreaDenina merged 1 commit into from
Feb 1, 2025
Merged

bug fixes realated to indexes in ack and nack handling #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions src/drone.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,13 @@ impl RustasticDrone {
/// ```
fn handle_ack_nack(&mut self, mut packet: Packet) {
if packet.routing_header.hop_index >= packet.routing_header.hops.len() {
// It can't happen
unreachable!("{} Source is not a client!", "PANIC".purple());
error!(
"{} Invalid hop index increment detected in [ Drone: {} ] for header of Packet [ session_id: {} ]",
"✗".red(),
self.id,
packet.session_id
);
return;
}
if let PacketType::Nack(nack) = packet.clone().pack_type {
warn!(
Expand Down Expand Up @@ -439,9 +444,9 @@ impl RustasticDrone {
);

// Resend the fragment, reverse the path
packet.routing_header.hop_index -= 1;
//packet.routing_header.hop_index -= 1;
packet.routing_header.reverse();
packet.routing_header.hop_index += 1;
//packet.routing_header.hop_index += 1;
let new_packet = Packet {
pack_type: PacketType::MsgFragment(fragment.clone()),
routing_header: packet.routing_header.clone(),
Expand All @@ -455,15 +460,6 @@ impl RustasticDrone {
self.send_message(packet);
}
} else {
if packet.routing_header.hop_index == packet.routing_header.hops.len() - 1 {
error!(
"{} Invalid hop index increment detected in [ Drone: {} ] for header of Packet [ session_id: {} ]",
"✗".red(),
self.id,
packet.session_id
);
return;
}
self.send_message(packet);
}
}
Expand Down