Skip to content

Conversation

@henrylay97
Copy link
Member

@henrylay97 henrylay97 commented Nov 19, 2025

There is a long term bug in the PandoraModularShower (post-pandora, not pandora itself) algorithm that relates to the “best plane” that is assigned to each shower.
The idea of the best plane field is that it indicates which plane we should use for calorimetry (energy and dE/dx).
Currently, the best plane is associated with just dE/dx and is often incorrectly assigned to plane 0 (the first induction plane).

This is a hotfix for the SBND Fall Validation II production, which allows for separate calculations for dE/dx and energy. Details of the work towards this hotfix (and the full fix that will follow can be found in these slides. A shortened version of these slides will be presented in Friday's First Analyses meeting.

An accompanying PR exists to fill this information: SBNSoftware/sbnanaobj#176

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Fall Production Nov 19, 2025
@kjplows kjplows moved this to Partially reviewed in SBN software development Nov 19, 2025
@linyan-w linyan-w moved this from Waiting on Reviewer to Expected for validation II MC in SBND 2025 Fall Production Nov 19, 2025
Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The performance in the attached slides also are very similar to that of the full fix. Maybe the difference is that we lose the info from the no best plane events. Anyways, this looks good. Thanks Henry!

@nathanielerowe nathanielerowe moved this from Expected for validation II MC to Reviewer Approved in SBND 2025 Fall Production Nov 20, 2025
@kjplows kjplows moved this from Partially reviewed to Testing in SBN software development Nov 20, 2025
@kjplows
Copy link
Contributor

kjplows commented Nov 20, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbnanaobj#176

@kjplows kjplows moved this from Reviewer Approved to Ready for CI in SBND 2025 Fall Production Nov 20, 2025
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Nov 20, 2025
@kjplows kjplows moved this from Ready for CI to RM Approved in SBND 2025 Fall Production Nov 20, 2025
@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows merged commit f46cc95 into develop Nov 21, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Nov 21, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Nov 21, 2025
@nathanielerowe nathanielerowe moved this from RM Approved to In tagged release in SBND 2025 Fall Production Nov 22, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

7 participants