-
Notifications
You must be signed in to change notification settings - Fork 35
Hotfix to Shower Best Plane Calorimetry #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
linyan-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The performance in the attached slides also are very similar to that of the full fix. Maybe the difference is that we lose the info from the no best plane events. Anyways, this looks good. Thanks Henry!
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbnanaobj#176 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
There is a long term bug in the PandoraModularShower (post-pandora, not pandora itself) algorithm that relates to the “best plane” that is assigned to each shower.
The idea of the best plane field is that it indicates which plane we should use for calorimetry (energy and dE/dx).
Currently, the best plane is associated with just dE/dx and is often incorrectly assigned to plane 0 (the first induction plane).
This is a hotfix for the SBND Fall Validation II production, which allows for separate calculations for dE/dx and energy. Details of the work towards this hotfix (and the full fix that will follow can be found in these slides. A shortened version of these slides will be presented in Friday's First Analyses meeting.
An accompanying PR exists to fill this information: SBNSoftware/sbnanaobj#176