-
Notifications
You must be signed in to change notification settings - Fork 35
G4InfoReducer and SimpleMerge are part of larg4 #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G4InfoReducer and SimpleMerge are part of larg4 #612
Conversation
|
The tests are being triggered in jenkins. |
|
+LArSoft tests OK on slf7 for c14:prof |
|
+LArSoft tests OK on slf7 for e26:prof |
|
-SBND tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof |
|
-ICARUS tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof |
|
-uBooNE tests failed on slf7 for e26:prof |
|
-DUNE tests failed on slf7 for e26:prof |
|
This PR is needed for larsoft v10_14_01 |
|
Hi @lgarren, thanks for highlighting this! This will be picked up with the next sbncode release. |
larg4 PRs 58 and 56 added
G4InfoReducerandSimpleMergetolarg4/Core. The corresponding fcl files were added tolarg4/fcl. However, larg4/Core/CMakeLists.txtwas not modified to build the modules. The problem was reported in redmine issue #30201 and fixed in LArSoft/larg4#59 . This is a companion PR to remove the files from sbncode to avoid duplication.@LauPM you may wish to comment.