Skip to content

Conversation

@lgarren
Copy link
Contributor

@lgarren lgarren commented Dec 4, 2025

larg4 PRs 58 and 56 added G4InfoReducer and SimpleMerge to larg4/Core. The corresponding fcl files were added to larg4/fcl. However, larg4/Core/CMakeLists.txt was not modified to build the modules. The problem was reported in redmine issue #30201 and fixed in LArSoft/larg4#59 . This is a companion PR to remove the files from sbncode to avoid duplication.

@LauPM you may wish to comment.

@FNALbuild
Copy link

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larg4#59

@FNALbuild
Copy link

@FNALbuild
Copy link

@FNALbuild
Copy link

-SBND tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/19370&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28632&builds=

@FNALbuild
Copy link

-ICARUS tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/13608&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28632&builds=

@FNALbuild
Copy link

@FNALbuild
Copy link

@lgarren
Copy link
Contributor Author

lgarren commented Dec 5, 2025

This PR is needed for larsoft v10_14_01

@kjplows kjplows self-assigned this Dec 8, 2025
@kjplows kjplows self-requested a review December 8, 2025 20:37
@kjplows
Copy link
Contributor

kjplows commented Dec 8, 2025

Hi @lgarren, thanks for highlighting this! This will be picked up with the next sbncode release.

@kjplows kjplows merged commit acd7a8b into SBNSoftware:develop Dec 17, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Dec 17, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Recently done

Development

Successfully merging this pull request may close these issues.

3 participants